From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager v3 05/12] ui: registry: add view with key pool and node status
Date: Tue, 19 May 2026 17:08:58 +0200 [thread overview]
Message-ID: <177920333892.90544.12661132965173640598.b4-review@b4> (raw)
In-Reply-To: <20260515074623.766766-6-t.lamprecht@proxmox.com>
On Fri, 15 May 2026 09:43:15 +0200, Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
> diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/configuration/subscription_registry.rs
> new file mode 100644
> index 0000000..513fa3a
> --- /dev/null
> +++ b/ui/src/configuration/subscription_registry.rs
> @@ -0,0 +1,1019 @@
> [ ... skip 151 lines ... ]
> +
> + let mut tree = SlabTree::new();
> + let mut root = tree.set_root(NodeTreeEntry::Root);
> + root.set_expanded(true);
> +
> + for (remote_name, remote_nodes) in &by_remote {
↑ could drop the `&` here and avoid the `n.clone()` below…
> [ ... skip 18 lines ... ]
> + total,
> + });
> + remote_entry.set_expanded(true);
> + for n in remote_nodes {
> + remote_entry.append(NodeTreeEntry::Node {
> + data: n.clone(),
… here ↑
--
next prev parent reply other threads:[~2026-05-19 15:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 7:43 [PATCH datacenter-manager v3 00/12] subscription key pool registry Thomas Lamprecht
2026-05-15 7:43 ` [PATCH datacenter-manager v3 01/12] api types: subscription level: render full names Thomas Lamprecht
2026-05-15 7:43 ` [PATCH datacenter-manager v3 02/12] pdm-client: add wait_for_local_task helper Thomas Lamprecht
2026-05-15 15:21 ` Wolfgang Bumiller
2026-05-15 7:43 ` [PATCH datacenter-manager v3 03/12] subscription: pool: add data model and config layer Thomas Lamprecht
2026-05-15 15:21 ` Wolfgang Bumiller
2026-05-15 7:43 ` [PATCH datacenter-manager v3 04/12] subscription: api: add key pool and node status endpoints Thomas Lamprecht
2026-05-15 15:21 ` Wolfgang Bumiller
2026-05-18 14:27 ` Lukas Wagner
2026-05-15 7:43 ` [PATCH datacenter-manager v3 05/12] ui: registry: add view with key pool and node status Thomas Lamprecht
2026-05-19 15:08 ` Wolfgang Bumiller [this message]
2026-05-15 7:43 ` [PATCH datacenter-manager v3 06/12] cli: client: add subscription key pool management subcommands Thomas Lamprecht
2026-05-15 7:43 ` [PATCH datacenter-manager v3 07/12] docs: add subscription registry chapter Thomas Lamprecht
2026-05-15 7:43 ` [PATCH datacenter-manager v3 08/12] subscription: add Clear Key action and per-node revert Thomas Lamprecht
2026-05-15 7:43 ` [PATCH datacenter-manager v3 09/12] subscription: add Adopt Key action for foreign live subscriptions Thomas Lamprecht
2026-05-15 7:43 ` [PATCH datacenter-manager v3 10/12] subscription: add Adopt All bulk action Thomas Lamprecht
2026-05-15 7:43 ` [PATCH datacenter-manager v3 11/12] subscription: add Check Subscription action Thomas Lamprecht
2026-05-15 7:43 ` [RFC PATCH datacenter-manager v3 12/12] ui: registry: add Add-and-Assign wizard from Assign Key dialog Thomas Lamprecht
2026-05-18 13:41 ` Lukas Wagner
2026-05-18 13:23 ` [PATCH datacenter-manager v3 00/12] subscription key pool registry Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177920333892.90544.12661132965173640598.b4-review@b4 \
--to=w.bumiller@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox