From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 25A751FF17A for ; Tue, 9 Dec 2025 18:49:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5223EA5FD; Tue, 9 Dec 2025 18:50:33 +0100 (CET) From: Thomas Lamprecht To: pdm-devel@lists.proxmox.com, "Max R. Carrara" Date: Tue, 9 Dec 2025 17:43:54 +0100 Message-ID: <176529862855.88133.273053272928153672.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251203191713.942001-1-m.carrara@proxmox.com> References: <20251203191713.942001-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765302624354 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mozilla.org] Subject: [pdm-devel] applied: [PATCH datacenter-manager v1] ui: remote wizard: fix "invalid uri character" when adding PBS remote X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Wed, 03 Dec 2025 20:17:11 +0100, Max R. Carrara wrote: > ... by normalizing the hostname in the form context directly when the > user clicks on "Next" in the remote addition wizard. > > This is necessary because the wizard takes the values for submission > directly from its form context. > > This is somewhat easy to run into, e.g. if one copy-pastes the URL of > the PBS remote to add from another browser tab. > > [...] Applied, thanks! btw. might be also nice to extend normalize_hostname such that it also removes hash anchor parts from the URL, as those are also often there if one copies the full URL from the address bar of a PBS or PVE's web UI browser tab. FWIW, there is a web APIs to pare an URL [0], so it might be sensible to use that API if the URL starts with `https?://` and get the host (hostname + port) from there rather than continuing to heuristically strip away parts. [0]: https://developer.mozilla.org/en-US/docs/Web/API/URL/parse_static [1/1] ui: remote wizard: fix "invalid uri character" when adding PBS remote commit: ca5a7957af2be8110d4a1052a60e10606f22e498 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel