From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4A3BC1FF17E for ; Thu, 27 Nov 2025 14:22:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 368603976; Thu, 27 Nov 2025 14:23:03 +0100 (CET) From: Thomas Lamprecht To: pdm-devel@lists.proxmox.com, Lukas Wagner Date: Thu, 27 Nov 2025 14:22:50 +0100 Message-ID: <176424974621.2064208.7118621784002386431.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251120110033.160931-1-l.wagner@proxmox.com> References: <20251120110033.160931-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764249741993 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] applied: [PATCH proxmox v2] rrd: update_value: restrict archive file path X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Thu, 20 Nov 2025 12:00:33 +0100, Lukas Wagner wrote: > The `rel_path` parameter is used as a relative path inside the `rrdb` > base directory to build the final path for the archive file. Usually, > this is something like 'node/localhost/cpu_avg1'. For PBS, this is fine, > since these paths are hardcoded or derived from safe datastore names. In > PDM however, these paths are built from potentially 'untrusted' (as in, > one could 'pretend' to be a PBS/PVE remote and send malicious data) > metric data points - so we should have additional safe guards in place > to disallow potentially dangerous paths like '../abc' which would escape > the base directory. > > [...] Applied, thanks! [1/1] rrd: update_value: restrict archive file path commit: 948b0f0f3b66656cb4e5e9d00e7a2bc8ce9fc0ea _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel