From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 05A891FF179 for ; Wed, 29 Oct 2025 15:13:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8CA7CCF92; Wed, 29 Oct 2025 15:14:12 +0100 (CET) From: Thomas Lamprecht To: pdm-devel@lists.proxmox.com, Fiona Ebner Date: Wed, 29 Oct 2025 15:09:28 +0100 Message-ID: <176174696524.1776006.10760334798456181474.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251029134638.125532-2-f.ebner@proxmox.com> References: <20251029134638.125532-1-f.ebner@proxmox.com> <20251029134638.125532-2-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761747206304 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] applied: [PATCH datacenter-manager 1/1] ui: remote wizard: validate remote ID X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Wed, 29 Oct 2025 14:46:27 +0100, Fiona Ebner wrote: > As reported in the community forum [0], the remote ID field in the > remote wizard was not validated. When using an inavlid remote ID, only > the backend would report an error upon submission. Add validation to > the 'Remote ID' field to catch this early. > > [0]: https://forum.proxmox.com/threads/171742/post-808943 > > [...] Applied, thanks! Tiny nit, but as I noticed it more than a few times now already: Personally I'm not a big fan of cover-letters for simple single-patch submissions, just adds noise. Basically I'd prefer: - single commit -> single patch and no cover letter, it's basically just a `git send-email -1` call anyway. - multiple commits -> always a cover letter. But if I'd have to chose between either always cover-letter or never I'd go for always, so it's fine for me, just find it unnecessary and cost my slightly more time to read a extra post to see if there is anything that special that warrants a cover-letter for "just" a single patch. [1/1] ui: remote wizard: validate remote ID commit: 0e013085a1d6ed8b70cdb16f4d51af4f6b2f301f _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel