From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 67F141FF168
	for <inbox@lore.proxmox.com>; Tue,  7 Jan 2025 13:13:51 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id D4E092E3A;
	Tue,  7 Jan 2025 13:13:39 +0100 (CET)
Date: Tue, 7 Jan 2025 13:13:33 +0100 (CET)
From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <1691757507.6745.1736252013013@webmail.proxmox.com>
In-Reply-To: <20250107112934.1710402-1-d.csapak@proxmox.com>
References: <20250107112934.1710402-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev71
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.047 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pdm-devel] [PATCH datacenter-manager] ui: remote migrate: lxc:
 add missing 'target-vmid' property
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>

this is https://bugzilla.proxmox.com/show_bug.cgi?id=6016

> Dominik Csapak <d.csapak@proxmox.com> hat am 07.01.2025 12:29 CET geschrieben:
> 
>  
> while we added that for vms already, it was missing for containers
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/widget/migrate_window.rs | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/ui/src/widget/migrate_window.rs b/ui/src/widget/migrate_window.rs
> index 1649296..c87cf9a 100644
> --- a/ui/src/widget/migrate_window.rs
> +++ b/ui/src/widget/migrate_window.rs
> @@ -183,6 +183,10 @@ impl PdmMigrateWindow {
>                          .delete_source(value["delete-source"].as_bool().unwrap_or_default())
>                          .restart(true, None);
>  
> +                    if let Some(Value::Number(vmid)) = value.get("target-vmid") {
> +                        migrate_opts = migrate_opts.target_vmid(vmid.as_u64().unwrap() as u32);
> +                    }
> +
>                      if form_ctx.read().get_field_checked("detailed-mode") {
>                          match value.get("detail-map") {
>                              Some(Value::Array(list)) => {
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pdm-devel mailing list
> pdm-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel