[pdm-devel] [PATCH datacenter-manager] ui: remote migrate: lxc: add missing 'target-vmid' property

[pdm-devel] [PATCH datacenter-manager] ui: remote migrate: lxc: add missing 'target-vmid' property

[Dominik Csapak]

while we added that for vms already, it was missing for containers

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/widget/migrate_window.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ui/src/widget/migrate_window.rs b/ui/src/widget/migrate_window.rs
index 1649296..c87cf9a 100644
--- a/ui/src/widget/migrate_window.rs
+++ b/ui/src/widget/migrate_window.rs
@@ -183,6 +183,10 @@ impl PdmMigrateWindow {
                         .delete_source(value["delete-source"].as_bool().unwrap_or_default())
                         .restart(true, None);
 
+                    if let Some(Value::Number(vmid)) = value.get("target-vmid") {
+                        migrate_opts = migrate_opts.target_vmid(vmid.as_u64().unwrap() as u32);
+                    }
+
                     if form_ctx.read().get_field_checked("detailed-mode") {
                         match value.get("detail-map") {
                             Some(Value::Array(list)) => {
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] ui: remote migrate: lxc: add missing 'target-vmid' property

[Fabian Grünbichler]

this is https://bugzilla.proxmox.com/show_bug.cgi?id=6016

> Dominik Csapak <d.csapak@proxmox.com> hat am 07.01.2025 12:29 CET geschrieben:
> 
>  
> while we added that for vms already, it was missing for containers
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/widget/migrate_window.rs | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/ui/src/widget/migrate_window.rs b/ui/src/widget/migrate_window.rs
> index 1649296..c87cf9a 100644
> --- a/ui/src/widget/migrate_window.rs
> +++ b/ui/src/widget/migrate_window.rs
> @@ -183,6 +183,10 @@ impl PdmMigrateWindow {
>                          .delete_source(value["delete-source"].as_bool().unwrap_or_default())
>                          .restart(true, None);
>  
> +                    if let Some(Value::Number(vmid)) = value.get("target-vmid") {
> +                        migrate_opts = migrate_opts.target_vmid(vmid.as_u64().unwrap() as u32);
> +                    }
> +
>                      if form_ctx.read().get_field_checked("detailed-mode") {
>                          match value.get("detail-map") {
>                              Some(Value::Array(list)) => {
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pdm-devel mailing list
> pdm-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] applied: [PATCH datacenter-manager] ui: remote migrate: lxc: add missing 'target-vmid' property

[Thomas Lamprecht]

On 07/01/2025 12:29, Dominik Csapak wrote:
> while we added that for vms already, it was missing for containers
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/widget/migrate_window.rs | 4 ++++
>  1 file changed, 4 insertions(+)
> 
>

applied, with bug # added to commit message, thanks!


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel