From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E62361FF16B for ; Tue, 26 Aug 2025 14:42:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 05E5B324F9; Tue, 26 Aug 2025 14:42:32 +0200 (CEST) Message-ID: <0612f831-cf3f-4a35-b137-d57db2633f80@proxmox.com> Date: Tue, 26 Aug 2025 14:41:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Datacenter Manager development discussion , Dominik Csapak References: <20250826102229.2271453-1-d.csapak@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20250826102229.2271453-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.706 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs, tasks.rs, mod.rs] Subject: Re: [pdm-devel] [PATCH datacenter-manager v4 0/8] add task summary panels in dashboard X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Looked at the changes - series LGTM from my POV now. I also gave this another quick spin on my PDM instance: Ran some tasks and re-checked the Dashboard overview if the information has been correctly updated / applied. Did cover each remote / task type / result type (ok, warning, ..) once with the tasks I ran. Played with the different duration settings as well. Consider this: Reviewed-by: Stefan Hanreich Tested-by: Stefan Hanreich On 8/26/25 12:22 PM, Dominik Csapak wrote: > This adds new panels to the dashboard for showing summaries of the tasks: > * one by category > * one by remote > > similar to what we have in PBS. > > I did not implement a cache for the data on the backend, but this can be > done as a follow up and should not impact the UI code at all. > > changes from v3: > * instead of having freestanding helper functions, introduce a struct > with methods that we can pass around, this makes it easier to sort, > etc. also with this we can get rid of another helper type in the > tasks ui > * changed to a btreemap from a hashmap to keep the sorting we get from > the TaskWorkerType > * deduplicated the since/hour calculation in the dashboard > > > changes from v2: > * rebase on current master (incl task caching changes from lukas) > * new patch (8/8) that includes configuring the time frame to check the > tasks for > > Changes from v1: > * incorporated most suggestions from Thomas > * split up patches a bit > * added new server api call > * (the UI code is very different to accomodate the necessary changes) > > > > Dominik Csapak (8): > server: task cache: treat a limit of 0 as unbounded > server: api: remote tasks: add 'remote' filter option > server: api: add remote-tasks statistics > ui: refactor remote upid formatter > ui: tasks: add helper to summarize task categories > ui: add dialog to show filtered tasks > ui: dashboard: add task summaries > ui: dashboard: make task summary time range configurable > > lib/pdm-api-types/src/lib.rs | 46 +++++ > server/src/api/remote_tasks.rs | 88 ++++++++- > server/src/remote_tasks/mod.rs | 17 +- > ui/src/dashboard/filtered_tasks.rs | 291 ++++++++++++++++++++++++++++ > ui/src/dashboard/mod.rs | 128 +++++++++++- > ui/src/dashboard/tasks.rs | 301 +++++++++++++++++++++++++++++ > ui/src/remotes/tasks.rs | 19 +- > ui/src/tasks.rs | 103 +++++++++- > ui/src/top_nav_bar.rs | 18 +- > 9 files changed, 966 insertions(+), 45 deletions(-) > create mode 100644 ui/src/dashboard/filtered_tasks.rs > create mode 100644 ui/src/dashboard/tasks.rs > _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel