From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 04747AC75 for ; Tue, 8 Aug 2023 11:48:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9E007D95 for ; Tue, 8 Aug 2023 11:48:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 8 Aug 2023 11:48:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0AEEB4370D for ; Tue, 8 Aug 2023 11:48:25 +0200 (CEST) Date: Tue, 8 Aug 2023 11:48:23 +0200 From: Wolfgang Bumiller To: Lukas Wagner Cc: pbs-devel@lists.proxmox.com Message-ID: References: <20230808094454.218381-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808094454.218381-1-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 1 AWL 0.108 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH v2 proxmox] clippy fix: casting to the same type is unnecessary X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Aug 2023 09:48:26 -0000 applied, thanks On Tue, Aug 08, 2023 at 11:44:54AM +0200, Lukas Wagner wrote: > See: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast > > Signed-off-by: Lukas Wagner > --- > proxmox-time/src/posix.rs | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/proxmox-time/src/posix.rs b/proxmox-time/src/posix.rs > index 3201d6a..6157f8b 100644 > --- a/proxmox-time/src/posix.rs > +++ b/proxmox-time/src/posix.rs > @@ -137,6 +137,10 @@ pub fn strftime(format: &str, t: &libc::tm) -> Result { > // -1,, it's unsigned > bail!("strftime failed"); > } > + > + // `res` is a `libc::size_t`, which on a different target architecture might not be directly > + // assignable to a `usize`. Thus, we actually want a cast here. > + #[allow(clippy::unnecessary_cast)] > let len = res as usize; > > if len == 0 { > -- > 2.39.2