From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9C22E1FF168 for ; Tue, 26 Nov 2024 11:01:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 489E12BB29; Tue, 26 Nov 2024 11:01:56 +0100 (CET) Date: Tue, 26 Nov 2024 11:01:52 +0100 From: Gabriel Goller To: Thomas Lamprecht Message-ID: References: <20240913131033.396324-1-g.goller@proxmox.com> <20240913131033.396324-7-g.goller@proxmox.com> <051476db-154f-49be-ae4b-fd764c22de5e@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <051476db-154f-49be-ae4b-fd764c22de5e@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup v4 6/7] ui: show consent banner before login X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 25.11.2024 19:12, Thomas Lamprecht wrote: >Am 13.09.24 um 15:10 schrieb Gabriel Goller: >> Before showing the LoginView, check if we got a non-empty consent text >> from the template. If there is a non-empty text, display it in a modal. >> >> Signed-off-by: Gabriel Goller >> --- >> www/LoginView.js | 12 ++++++++++++ >> www/config/NodeOptionView.js | 6 ++++++ >> www/index.hbs | 1 + >> 3 files changed, 19 insertions(+) >> >> > >applied, with the indentation mess in the init function a bit improved, thanks! Thanks! >btw. onnlineHelp link would be great, IMO it's a bit of a confusing setting as >is. Will send two follow-up patches with this one and the small nit on the first commit! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel