From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D670BB5C1 for ; Wed, 9 Aug 2023 12:57:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B834C1409F for ; Wed, 9 Aug 2023 12:57:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 9 Aug 2023 12:57:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7F8314352B for ; Wed, 9 Aug 2023 12:57:00 +0200 (CEST) Date: Wed, 9 Aug 2023 12:57:00 +0200 From: Christoph Heiss To: Lukas Wagner Cc: Proxmox Backup Server development discussion Message-ID: References: <20230808122239.1025524-1-c.heiss@proxmox.com> <20230808122239.1025524-13-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-widget-toolkit 12/12] window: add Active Directory auth panel X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Aug 2023 10:57:31 -0000 On Wed, Aug 09, 2023 at 12:13:24PM +0200, Lukas Wagner wrote: > > On Tue Aug 8, 2023 at 2:22 PM CEST, Christoph Heiss wrote: > > As AD realms are mostly just LDAP, reuse the LDAP panel and just > > show/hide some elements based on the type. > > Maybe it would make sense to also change the the bind-dn field, so that it > shows the (I think) more common AD-syntax in its empty text (user@ > instead of the LDAP DN syntax). A tooltip indicating that you can use both > variants could be helpful as well. Seems very sensible, I will add/change that - same for the documentation regarding the same thing, as you mentioned in your previously email. Thanks for the suggestion! > > Also, I noticed that when updating the realm, the value of the 'case-sensitive' > checkbox is not persisted when changed (seems like the reason is that the > update handler in proxmox-backup's API does not consider the parameter at all) Yeah, I forgot to add that bit to the update handler, will fix that.