From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 72C8A1FF16F
for <inbox@lore.proxmox.com>; Tue, 15 Apr 2025 12:13:42 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D6B3241ED;
Tue, 15 Apr 2025 12:13:40 +0200 (CEST)
Date: Tue, 15 Apr 2025 12:13:06 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Message-ID: <u3s3d5czhqlaud7wgnmb6h4epboucnbt6an4ogu4drh2hwj2h4@7vizwdzvi6m2>
References: <20250415091115.97664-1-c.ebner@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250415091115.97664-1-c.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.082 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com]
Subject: [pbs-devel] applied: [PATCH proxmox-backup] api: backup: include
previous snapshot name in log message
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
applied, thanks
On Tue, Apr 15, 2025 at 11:11:15AM +0200, Christian Ebner wrote:
> Extends the log messages written to the server's backup worker task
> log to include the snapshot name which is used as previous snapshot.
>
> This information facilitates debugging efforts, as the previous
> snapshot might have been pruned since.
>
> For example, instead of
> ```
> download 'index.json.blob' from previous backup.
> register chunks in 'drive-scsi0.img.fidx' from previous backup.
> download 'drive-scsi0.img.fidx' from previous backup.
> ```
>
> this now logs
> ```
> download 'index.json.blob' from previous backup 'vm/101/2025-04-15T09:02:10Z'.
> register chunks in 'drive-scsi0.img.fidx' from previous backup 'vm/101/2025-04-15T09:02:10Z'.
> download 'drive-scsi0.img.fidx' from previous backup 'vm/101/2025-04-15T09:02:10Z'.
> ```
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> This information is of great interest when debugging issues like, e.g.
> https://my.proxmox.com/en/dbsfk/ticket/view/17530
>
> src/api2/backup/mod.rs | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/src/api2/backup/mod.rs b/src/api2/backup/mod.rs
> index 344c80d46..629df933e 100644
> --- a/src/api2/backup/mod.rs
> +++ b/src/api2/backup/mod.rs
> @@ -853,8 +853,8 @@ fn download_previous(
> };
> if let Some(index) = index {
> env.log(format!(
> - "register chunks in '{}' from previous backup.",
> - archive_name
> + "register chunks in '{archive_name}' from previous backup '{}'.",
> + last_backup.backup_dir.dir(),
> ));
>
> for pos in 0..index.index_count() {
> @@ -865,7 +865,10 @@ fn download_previous(
> }
> }
>
> - env.log(format!("download '{}' from previous backup.", archive_name));
> + env.log(format!(
> + "download '{archive_name}' from previous backup '{}'.",
> + last_backup.backup_dir.dir(),
> + ));
> crate::api2::helpers::create_download_response(path).await
> }
> .boxed()
> --
> 2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel