From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 86EFE1FF15C
	for <inbox@lore.proxmox.com>; Wed, 27 Nov 2024 12:51:31 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id C37AB15C8A;
	Wed, 27 Nov 2024 12:51:32 +0100 (CET)
Date: Wed, 27 Nov 2024 12:50:58 +0100
From: Gabriel Goller <g.goller@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Message-ID: <tfagihoddbybnryxafsisgsz5o2iaqc7ity3wa7d7yehhoh2dg@csrwmiczir7e>
References: <20241127102737.81854-1-g.goller@proxmox.com>
 <123dbdc2-192c-4565-af00-927a86c1ffd9@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <123dbdc2-192c-4565-af00-927a86c1ffd9@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.037 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH] textareafield: add emptyText message to
 show markdown is possible
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

On 27.11.2024 11:29, Lukas Wagner wrote:
>On  2024-11-27 11:27, Gabriel Goller wrote:
>> Just like in our `Notes` fields show a emptyText message that explains
>> that markdown can be used.
>>
>> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>>  src/form/TextAreaField.js | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/form/TextAreaField.js b/src/form/TextAreaField.js
>> index 267b40c87d74..ed6015a9ec51 100644
>> --- a/src/form/TextAreaField.js
>> +++ b/src/form/TextAreaField.js
>> @@ -10,6 +10,7 @@ Ext.define('Proxmox.form.field.Base64TextArea', {
>>          width: 600,
>>          height: 400,
>>          scrollable: 'y',
>> +        emptyText: 'You can use Markdown for richt text formatting.',
>
>This should use gettext :)
>Also there is a typo in 'rich' :D

Ack, thanks for the review!
v2 is out!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel