From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AA7951FF394 for ; Mon, 3 Jun 2024 10:12:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C352F1CEC5; Mon, 3 Jun 2024 10:13:06 +0200 (CEST) Date: Mon, 3 Jun 2024 10:13:03 +0200 From: Wolfgang Bumiller To: Gabriel Goller Message-ID: References: <20240426123720.110120-1-g.goller@proxmox.com> <20240426123720.110120-2-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240426123720.110120-2-g.goller@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.090 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox v6 1/2] router: cli: add confirmation helper X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Thomas Lamprecht , pbs-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Missed something in the first response: We should `use anyhow::Error` rather than using `Result<_, anyhow::Error>` everywhere. On Fri, Apr 26, 2024 at 02:37:15PM GMT, Gabriel Goller wrote: > Add confirmation helper that outputs a prompt and lets the user > confirm or deny it. > Implemented to close #4763. > > Co-authored-by: Thomas Lamprecht > Signed-off-by: Gabriel Goller > --- > proxmox-router/Cargo.toml | 1 + > proxmox-router/src/cli/mod.rs | 113 +++++++++++++++++++++++++++++++++- > 2 files changed, 113 insertions(+), 1 deletion(-) > > diff --git a/proxmox-router/Cargo.toml b/proxmox-router/Cargo.toml > index dcd71a4..0b9d361 100644 > --- a/proxmox-router/Cargo.toml > +++ b/proxmox-router/Cargo.toml > @@ -19,6 +19,7 @@ percent-encoding.workspace = true > serde_json.workspace = true > serde.workspace = true > unicode-width ="0.1.8" > +regex.workspace = true > > # cli: > tokio = { workspace = true, features = [], optional = true } > diff --git a/proxmox-router/src/cli/mod.rs b/proxmox-router/src/cli/mod.rs > index 7df94ad..d13caa5 100644 > --- a/proxmox-router/src/cli/mod.rs > +++ b/proxmox-router/src/cli/mod.rs > @@ -12,7 +12,11 @@ > //! - Ability to create interactive commands (using ``rustyline``) > //! - Supports complex/nested commands > > -use std::collections::HashMap; > +use std::{ > + collections::HashMap, > + io::{self, Write}, > +}; (And add an empty line in between the std and external `use` group please.) > +use anyhow::bail; > > use crate::ApiMethod; > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel