From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A7F4F1FF136 for ; Mon, 23 Feb 2026 11:07:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C864F70BE; Mon, 23 Feb 2026 11:08:28 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Subject: superseded: [PATCH backup v2 0/3] fix #7054: client: remove trailing newlines from credentials In-Reply-To: <20260220123818.365489-1-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Fri, 20 Feb 2026 13:38:13 +0100") References: <20260220123818.365489-1-m.sandoval@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Mon, 23 Feb 2026 11:07:53 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771841259566 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.981 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.798 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.79 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.547 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TJGVJX2BG75KUMRNDX4ROYYGQSKTWNYG X-Message-ID-Hash: TJGVJX2BG75KUMRNDX4ROYYGQSKTWNYG X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Maximiliano Sandoval writes: > See the first commit for more details. > > This was tested with proxmox-backup-client making a login/backup using different > credentials with and without newlines. The commands were similar to the > systemd-run commands at the Backup Client Usage docs. > > I did not find a way to create the keyfile with newlines in its password using > proxmox-backup-client since it reads from the tty stdin, but surely it could be > created manually. Perhaps it is safe-ish to also remove trailing control > characters from the encryption password but this seems a safer approach for now. > > Diferences from v1: > - Always do an extra allocation to keep the code clean > - Rename password to blob > - Only strip newlines on passwords Superseded-by: https://lore.proxmox.com/all/20260223093710.36009-1-m.sandoval@proxmox.com/ -- Maximiliano