From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup] use truncate whenever we create files
Date: Wed, 15 Jan 2025 16:20:09 +0100 [thread overview]
Message-ID: <s8oo708qext.fsf@proxmox.com> (raw)
In-Reply-To: <1733221737.l98m8tuhwc.astroid@yuna.none>
Fabian Grünbichler <f.gruenbichler@proxmox.com> writes:
>> diff --git a/pbs-client/src/pxar/extract.rs b/pbs-client/src/pxar/extract.rs
>> index cfbd8d51..b3e7d535 100644
>> --- a/pbs-client/src/pxar/extract.rs
>> +++ b/pbs-client/src/pxar/extract.rs
>> @@ -134,6 +134,7 @@ where
>> if let Some(entry) = prelude {
>> let mut prelude_file = OpenOptions::new()
>> .create(true)
>> + .truncate(true)
>> .write(true)
>> .open(path)
>> .with_context(|| format!("error creating prelude file '{path:?}'"))?;
>
> this one should honor the overwrite flag and not truncate
> unconditionally (see below)
Sorry I am not following, the two diffs bellow use the same flags
(except that they also add `read(true)`).
>> diff --git a/src/api2/tape/restore.rs b/src/api2/tape/restore.rs
>> index 93a6053b..2cc1baab 100644
>> --- a/src/api2/tape/restore.rs
>> +++ b/src/api2/tape/restore.rs
>> @@ -1711,6 +1711,7 @@ fn try_restore_snapshot_archive<R: pxar::decoder::SeqRead>(
>> let mut tmpfile = std::fs::OpenOptions::new()
>> .write(true)
>> .create(true)
>> + .truncate(true)
>
> this is okay, provided the tape code has locked the snapshot path this
> is operating in (seems to be the case after a quick glance - @Dominik?)
>
>> .read(true)
>> .open(&tmp_path)
>> .map_err(|err| format_err!("restore {:?} failed - {}", tmp_path, err))?;
>> diff --git a/src/server/sync.rs b/src/server/sync.rs
>> index 0bd7a7a8..04654c28 100644
>> --- a/src/server/sync.rs
>> +++ b/src/server/sync.rs
>> @@ -159,6 +159,7 @@ impl SyncSourceReader for RemoteSourceReader {
>> let tmpfile = std::fs::OpenOptions::new()
>> .write(true)
>> .create(true)
>> + .truncate(true)
>
> this is in a locked context, so should be okay as well..
>
>> .read(true)
>> .open(&tmp_path)?;
>>
>> --
>> 2.39.5
>>
>>
>>
>> _______________________________________________
>> pbs-devel mailing list
>> pbs-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>>
>>
>>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-01-15 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 13:17 Maximiliano Sandoval
2024-12-03 10:40 ` Fabian Grünbichler
2025-01-15 15:20 ` Maximiliano Sandoval [this message]
2025-01-27 9:24 ` Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8oo708qext.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox