From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 54B079B0C9 for ; Mon, 20 Nov 2023 08:58:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3053714FDF for ; Mon, 20 Nov 2023 08:58:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 20 Nov 2023 08:58:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 738204332B for ; Mon, 20 Nov 2023 08:58:02 +0100 (CET) References: <20231117123739.157277-1-m.sandoval@proxmox.com> <20231117123739.157277-2-m.sandoval@proxmox.com> <5e68f9a1-ed8a-4493-9162-b4e285fc2685@proxmox.com> <1810775013.20.1700466862839@webmail.proxmox.com> User-agent: mu4e 1.10.7; emacs 29.1 From: Maximiliano Sandoval To: Fabian =?utf-8?Q?Gr=C3=BCnbichler?= Cc: Proxmox Backup Server development discussion , Thomas Lamprecht Date: Mon, 20 Nov 2023 08:55:57 +0100 In-reply-to: <1810775013.20.1700466862839@webmail.proxmox.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox 1/2] sys: Use safe wrapper for libc::isatty X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2023 07:58:33 -0000 Setting the MSRV is always a good idea. Will post a v2. Fabian Gr=C3=BCnbichler writes: >> Thomas Lamprecht hat am 19.11.2023 16:09 CET g= eschrieben: >> >> Am 17/11/2023 um 13:37 schrieb Maximiliano Sandoval R: >> > Use the `std::io::IsTerminal` trait introduced in Rust 1.70. >> >> ack, but a more general question: should we set the msrv in the manifest: >> >> rust-version =3D "1.70" >> >> We did not bothered to much with that until now, only a bit indirectly t= hrough >> increasing the edition to e.g., 2021, and we do not have that many exter= nal >> users for it to matter much. > > I think that would make sense. most recent debcargo versions (not yet for= us) translate this to the corresponding versioned dep, and the error messa= ges are also much nicer and earlier in case somebody tries to build with a = too old version.. -- Maximiliano