From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 972561FF15E for <inbox@lore.proxmox.com>; Fri, 9 Aug 2024 13:11:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8A20E3C9FB; Fri, 9 Aug 2024 13:11:59 +0200 (CEST) From: Maximiliano Sandoval <m.sandoval@proxmox.com> To: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <71a9f6ff-44b0-4ead-bd66-1344274e7f7a@proxmox.com> (Thomas Lamprecht's message of "Wed, 7 Aug 2024 20:59:37 +0200") References: <20240807074356.83378-1-m.sandoval@proxmox.com> <71a9f6ff-44b0-4ead-bd66-1344274e7f7a@proxmox.com> Date: Fri, 09 Aug 2024 13:11:24 +0200 Message-ID: <s8o8qx6ar37.fsf@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 1 AWL 0.116 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [github.io] Subject: Re: [pbs-devel] applied-series: [PATCH proxmox 01/10] clippy: remove needless borrow X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> Thomas Lamprecht <t.lamprecht@proxmox.com> writes: > On 07/08/2024 09:43, Maximiliano Sandoval wrote: >> Fixes the clippy warning: >> >> warning: this expression borrows a value the compiler would automatically borrow >> --> proxmox-apt/src/repositories/file/sources_parser.rs:111:40 >> | >> 111 | ... types.push((&package_type[..]).parse()?); >> | ^^^^^^^^^^^^^^^^^^^ help: change this to: `package_type[..]` >> | >> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow >> = note: `#[warn(clippy::needless_borrow)]` on by default >> >> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com> > > applied series with Lukas' R-b, thanks! Thanks! I don't see the first commit in the series ()`clippy: remove needless borrow`) in the repository, is it possible that it slipped by? -- Maximiliano _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel