From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D96F21FF56B for ; Mon, 22 Apr 2024 15:58:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 12D0213475; Mon, 22 Apr 2024 15:58:51 +0200 (CEST) From: Maximiliano Sandoval To: Proxmox Backup Server development discussion In-Reply-To: <20240422123841.280675-1-l.wagner@proxmox.com> (Lukas Wagner's message of "Mon, 22 Apr 2024 14:37:58 +0200") References: <20240422123841.280675-1-l.wagner@proxmox.com> User-Agent: mu4e 1.12.4; emacs 29.3 Date: Mon, 22 Apr 2024 15:58:17 +0200 Message-ID: MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record TVD_PH_BODY_ACCOUNTS_PRE 0.001 The body matches phrases such as "accounts suspended", "account credited", "account verification" Subject: Re: [pbs-devel] [PATCH many v4 00/43] integrate notification system X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Lukas Wagner writes: > These patches integrate the notification system which was introduced in Proxmox VE > in 8.1 into Proxmox Backup Server. I tested v3 of this patch series. Tested that the following things work as expected: - Error notification sent for ACME accounts - GC notification - verification notification - Legacy vs Notification system - Adding a matcher for successful prunes and receiving a prune notification I already discussed this with Lukas off-list: When a notification is queued and it does not match any matcher it should be logged, e.g. with a message ``` proxmox-backup-proxy[PID]: discarding notification (id=NOTIFICATION_ID). it does not match any matcher ``` otherwise the journal will only show: ``` Apr 22 11:19:50 pbs proxmox-backup-proxy[21341]: queued notification (id=5ae8da0a-afa7-4635-9d67-1645e6c47310) ``` and no reason of why such notification was never sent. Tested-by: Maximiliano Sandoval -- Maximiliano _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel