From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 632B11FF16C
for <inbox@lore.proxmox.com>; Fri, 16 Aug 2024 14:50:27 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C009B16E62;
Fri, 16 Aug 2024 14:50:43 +0200 (CEST)
Date: Fri, 16 Aug 2024 14:50:10 +0200
From: Christoph Heiss <c.heiss@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>
Message-ID: <rbnazo6hma5ook7cgmsbcz7by2ky3txlg7sjmsg2ddwsclf7hq@lpfxwx3lvpaj>
References: <20240816111648.483368-1-c.heiss@proxmox.com>
<20240816111648.483368-4-c.heiss@proxmox.com>
<20240816122339.a5v45llqoxkvli6k@luna.proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20240816122339.a5v45llqoxkvli6k@luna.proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.033 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pbs-devel] [PATCH widget-toolkit v3 03/14] window: add panel
for editing simple, built-in realms
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
Thanks for the review!
On Fri, Aug 16, 2024 at 02:23:39PM GMT, Gabriel Goller wrote:
> On 16.08.2024 13:16, Christoph Heiss wrote:
> > diff --git a/src/window/AuthEditSimple.js b/src/window/AuthEditSimple.js
> > new file mode 100644
> > index 0000000..22932c0
> > --- /dev/null
> > +++ b/src/window/AuthEditSimple.js
> > @@ -0,0 +1,41 @@
> > +Ext.define('Proxmox.panel.SimpleRealmInputPanel', {
> > + extend: 'Proxmox.panel.InputPanel',
> > + xtype: 'pmxAuthSimplePanel',
> > + mixins: ['Proxmox.Mixin.CBind'],
> > +
> > + type: 'simple',
> > +
> > + column1: [
> > + {
> > + xtype: 'pmxDisplayEditField',
> > + name: 'realm',
> > + cbind: {
> > + value: '{realm}',
> > + },
> > + fieldLabel: gettext('Realm'),
> > + allowBlank: false,
>
> Hmm I think `allowBlank` is useless here, as it's not editable.
Good catch! I've took the LDAP panel as base, where this field *can* be
editable. I'll remove it with the next revision.
>
> > [..]
> > + columnB: [
> > + {
> > + xtype: 'proxmoxtextfield',
> > + name: 'comment',
> > + fieldLabel: gettext('Comment'),
>
> But here `allowBlank: false` would be useful!
Sure, makes sense in that case!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel