From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <w.bumiller@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id C03009B6A
 for <pbs-devel@lists.proxmox.com>; Mon, 26 Jun 2023 14:59:44 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id A6C4728A47
 for <pbs-devel@lists.proxmox.com>; Mon, 26 Jun 2023 14:59:14 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Mon, 26 Jun 2023 14:59:14 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0A3C7442F5
 for <pbs-devel@lists.proxmox.com>; Mon, 26 Jun 2023 14:59:14 +0200 (CEST)
Date: Mon, 26 Jun 2023 14:59:13 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Stefan Sterz <s.sterz@proxmox.com>
Cc: Lukas Wagner <l.wagner@proxmox.com>, 
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <qfbswzlvygero4yeauramxjmyxwnibrpey2yflatsf5s5jab4j@k57a3zjpiokd>
References: <20230626093916.701659-1-s.sterz@proxmox.com>
 <20230626093916.701659-4-s.sterz@proxmox.com>
 <1d1111f0-7255-1c7a-a15c-eadaebefe257@proxmox.com>
 <2377ca93-1c8a-cfb5-d82e-11e12b85c4df@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2377ca93-1c8a-cfb5-d82e-11e12b85c4df@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.122 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/4] access: ldap check
 connection on creation and change
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 26 Jun 2023 12:59:44 -0000

On Mon, Jun 26, 2023 at 02:40:38PM +0200, Stefan Sterz wrote:
> On 26.06.23 14:36, Lukas Wagner wrote:
> > 
> > 
> > On 6/26/23 11:39, Stefan Sterz wrote:
> >>   macro_rules! DOMAIN_PART_REGEX {
> >>       () => {
> >> -        r#"("[^"]+"|[^ ,+"/<>;=#][^,+"/<>;=]*[^ ,+"/<>;=]|[^
> >> ,+"/<>;=#])"#
> >> +        r#"[^\s,\+=]+=(?:"[^"]+"|(?:\\[,\+=]|[^,\+=])+)"#
> >>       };
> >>   }
> >>   
> > 
> > I wonder, if we validate any change of the LDAP parameters against the
> > actual server anyway, is there
> > even any value in validating DNs using a regex?
> > 
> 
> it could be dropped, i just assumed that having it there would help in
> cases of obviously wrong dns and would save us the somewhat expensive
> round-trip in such cases.

I guess we can just drop it.