From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C23091FF38A for ; Fri, 28 Jun 2024 14:09:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A67EF36E27; Fri, 28 Jun 2024 14:09:51 +0200 (CEST) Date: Fri, 28 Jun 2024 14:09:47 +0200 From: Wolfgang Bumiller To: Christian Ebner Message-ID: References: <20240624142415.41470-1-c.ebner@proxmox.com> <1897229403.670.1719244415488@webmail.proxmox.com> <9114c156-ef5a-4ca1-8383-14dc087fe815@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9114c156-ef5a-4ca1-8383-14dc087fe815@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-rrd] cache: skip non-utf8 lines in rrd journal X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Mon, Jun 24, 2024 at 07:30:55PM GMT, Christian Ebner wrote: > On 6/24/24 17:53, Dietmar Maurer wrote: > > > In certain situations garbage might be written to the rrd journal, > > > e.g. by a hard crash of the host. > > > > Why does a host crash writes garbage to a file? > > I did not investigate any further how the file corruption might have > occurred: might be truncated output leading to incorrect, non-utf8 encoding > before the full line was written? Do we even have anything non-ASCII in that file? I'd think the file got corrupted some other way. So would we really want to apply it? Perhaps just let the admin clear/remove it? _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel