From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2CD2EB9CF7 for ; Tue, 12 Dec 2023 13:19:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0BBAF34750 for ; Tue, 12 Dec 2023 13:19:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 12 Dec 2023 13:19:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 35EE4469A7 for ; Tue, 12 Dec 2023 13:19:17 +0100 (CET) Date: Tue, 12 Dec 2023 13:19:16 +0100 From: Christoph Heiss To: Lukas Wagner Cc: Proxmox Backup Server development discussion Message-ID: References: <20230816144746.1265108-1-c.heiss@proxmox.com> <20230816144746.1265108-15-c.heiss@proxmox.com> <1bad223a-e8eb-4de4-8e06-556797f6a4f6@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1bad223a-e8eb-4de4-8e06-556797f6a4f6@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [RFC PATCH proxmox-backup v2 14/15] api: add case-insensitive support for Active Directory realms X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2023 12:19:18 -0000 Thanks a lot for testing! On Mon, Nov 27, 2023 at 10:57:03AM +0100, Lukas Wagner wrote: > > On 8/16/23 16:47, Christoph Heiss wrote: > > To properly support case-insensitive comparison of user names, > > `CachedUserInfo` first needs to gain logic whether to look up the userid > > in a case-sensitive or -insensitive manner. > > > > The API part is pretty straight-forward, adding a new `case-sensitive` > > parameter to the API (which is on-by-default). > > > > Mhmm, it seems this patch breaks user permissions if logging in as one of > the case-permutations of the original username. > > Assuming you have a user 'test@ad-realm' (mapping to 'test@ad.example.com' > on the AD server) and > the 'case-sensitive = false' in the AD realm settings, > you can login as 'Test@ad-realm' as well as 'test@ad-realm' - > however, if I give the 'test@ad-realm' user permissions for some resources, > e.g. a data store, the resource will not be accessible if I log in as > 'Test@ad-realm'. The case-insensitive stuff is really a PITA to retrofit properly, so I kind of expected for something to turn up .. Anyway, I'll look into it, thanks again!