From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 58EBF1FF168 for ; Tue, 26 Nov 2024 11:31:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 272C12C38A; Tue, 26 Nov 2024 11:31:59 +0100 (CET) Date: Tue, 26 Nov 2024 11:31:56 +0100 From: Gabriel Goller To: Thomas Lamprecht Message-ID: References: <20240913131033.396324-1-g.goller@proxmox.com> <20240913131033.396324-2-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mozilla.org] Subject: Re: [pbs-devel] [PATCH widget-toolkit v4 1/7] utils: add base64 conversion helper X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 17.09.2024 09:37, Thomas Lamprecht wrote: >On 13/09/2024 15:10, Gabriel Goller wrote: >> Add helper functions to convert from a utf8 string to a base64 string >> and vice-versa. Using the TextEncoder/TextDecoder we can support unicode >> such as emojis as well [0]. >> >> [0]: https://developer.mozilla.org/en-US/docs/Glossary/Base64#the_unicode_problem >> >> Signed-off-by: Gabriel Goller > >Reviewed-by: Thomas Lamprecht > >One small nit inline though. > >> --- >> src/Utils.js | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/src/Utils.js b/src/Utils.js >> index 7dd034a5e56f..3badb6aaf606 100644 >> --- a/src/Utils.js >> +++ b/src/Utils.js >> @@ -1356,6 +1356,24 @@ utilities: { >> ); >> }, >> >> + // Convert utf-8 string to base64. >> + // This also escapes unicode characters such as emojis. >> + utf8ToBase64: function(string) { >> + let bytes = new TextEncoder().encode(string); >> + const escapedString = Array.from(bytes, (byte) => >> + String.fromCodePoint(byte), >> + ).join(""); > >FWIW this could be a bit shorter by using map (which typed arrays >also support [0]): > > const escapedString = bytes.map(b => String.fromCodePoint(b)).join(''); > >But for that we really need no new revision. > >[0]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/map I just tried this and it sadly doesn't work. `String.fromCodePoint` returns a string, which can't be stored in the `Uint8Array` which is `bytes`. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel