From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C40F79E4DB for ; Mon, 27 Nov 2023 14:09:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 991027A29 for ; Mon, 27 Nov 2023 14:08:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 27 Nov 2023 14:08:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 51B4D44B47 for ; Mon, 27 Nov 2023 14:08:46 +0100 (CET) Date: Mon, 27 Nov 2023 14:08:45 +0100 From: Wolfgang Bumiller To: Gabriel Goller Cc: pbs-devel@lists.proxmox.com Message-ID: References: <20231127105238.99947-1-g.goller@proxmox.com> <20231127105238.99947-2-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231127105238.99947-2-g.goller@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs] Subject: Re: [pbs-devel] [PATCH v4 proxmox 1/3] sys: add function to get boot_mode X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2023 13:09:17 -0000 On Mon, Nov 27, 2023 at 11:52:36AM +0100, Gabriel Goller wrote: > Helper that returns the current boot_mode. Either EFI, BIOS, or EFI > (Secure Boot). > Detection works the same as in pve, we use `/sys/firmware/efi` and > the `efivars/SecureBoot-xxx..` file. > > Signed-off-by: Gabriel Goller > --- > proxmox-sys/src/boot_mode.rs | 54 ++++++++++++++++++++++++++++++++++++ > proxmox-sys/src/lib.rs | 1 + > 2 files changed, 55 insertions(+) > create mode 100644 proxmox-sys/src/boot_mode.rs > > diff --git a/proxmox-sys/src/boot_mode.rs b/proxmox-sys/src/boot_mode.rs > new file mode 100644 > index 0000000..6dcdf07 > --- /dev/null > +++ b/proxmox-sys/src/boot_mode.rs > @@ -0,0 +1,54 @@ > +use std::{io::Read, sync::Mutex}; > + > +#[derive(Clone, Copy)] > +pub enum SecureBoot { > + /// SecureBoot is enabled > + Enabled, > + /// SecureBoot is disabled > + Disabled, > +} > + > +/// The possible BootModes > +#[derive(Clone, Copy)] > +pub enum BootModeInformation { > + /// The BootMode is EFI/UEFI, has a SecureBoot variant > + Efi(SecureBoot), > + /// The BootMode is Legacy BIOS > + Bios, > +} > + > +// Returns the current bootmode (BIOS, EFI, or EFI(Secure Boot)) > +pub fn boot_mode() -> BootModeInformation { In addition to my v3 reply with the range comparison: please avoid more free-standing functions for this type of stuff. Instead, this could be BootModeInformation::query(). Also, are we sure we want this a a nested enum if we separate it in `pbs-api-types` later? Maybe these should just stay separate things, queried via BootMode::query() + SecureBoot::query() (A bit shorter with the `Information` suffix dropped there...)