From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3E9431FF16C for ; Tue, 3 Sep 2024 14:38:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E3F89B2D; Tue, 3 Sep 2024 14:39:05 +0200 (CEST) Date: Tue, 3 Sep 2024 14:38:32 +0200 From: Wolfgang Bumiller To: Gabriel Goller Message-ID: References: <20240829134040.335400-1-g.goller@proxmox.com> <20240903121051.cgl67w2ucciqpgig@luna.proxmox.com> <20240903122724.wlbllbvjm7bfdqy5@luna.proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240903122724.wlbllbvjm7bfdqy5@luna.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] applied: [PATCH v2] add tracing init_cli_logger and deprecate old one X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Tue, Sep 03, 2024 at 02:27:24PM GMT, Gabriel Goller wrote: > On 03.09.2024 14:21, Wolfgang Bumiller wrote: > > On Tue, Sep 03, 2024 at 02:10:51PM GMT, Gabriel Goller wrote: > > > Christian Ebner and I just noticed that previously all the output was on > > > stderr, because the `env_logger` prints everything to stderr > > > per-default [0]. This means that all the console output from > > > proxmox-backup-client, -manager, -debug, -file-restore, pxar, etc. is > > > now on stdout. > > > > > > There is one test failing in pxar-bin, but I have a patch ready for that > > > already. > > > > > > But will this cause more problems down the road? Do we rely somwhere on the > > > stderr output? Should I change the tracing output to stderr as well? > > > > > > [0]: https://docs.rs/env_logger/latest/env_logger/ > > > > Yeah having logs go to stderr would make sense. > > CLI tool output that is meant to be "useful" for *tooling* should be > > printed with `println!()` after all, not "logged". > > Ok, will send a patch soon! > Currently we nearly always log in our cli-tools, but maybe we should > start using println? I don't think we mostly log. Most of the time we call some API call and then use `format_and_print_result()` & friends. The point is not to *always* use `println!()` for everything, but for what is to be considered the actual "output" of the command. If there are cases where this is wrong, then yes, this should be corrected. I do wonder, though, whether CLI tools should move the default log level to "error". Most of the "info" level stuff shouldn't matter IMO. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel