From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E80AB1FF15D for <inbox@lore.proxmox.com>; Thu, 8 Aug 2024 16:25:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5A8011F332; Thu, 8 Aug 2024 16:25:12 +0200 (CEST) Date: Thu, 8 Aug 2024 16:25:08 +0200 From: Christoph Heiss <c.heiss@proxmox.com> To: Lukas Wagner <l.wagner@proxmox.com> Message-ID: <kl2wqxl3qp744fgcgnglfpt33glinbfdxzeryzzwpzhct5rs3a@xfbq6rpqcfnl> References: <20240716134514.1656795-1-c.heiss@proxmox.com> <d368ccd2-5c2f-4054-aa2d-4299c2d52b6d@proxmox.com> <xl6f7r5kgkafhhnvzs3e3qnqf5gmqrjrb6yyrl775y5tpipecx@eybahq3adgyc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <xl6f7r5kgkafhhnvzs3e3qnqf5gmqrjrb6yyrl775y5tpipecx@eybahq3adgyc> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup/pwt 0/14] fix #5379: introduce default auth realm option X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> On Wed, Aug 07, 2024 at 05:27:42PM GMT, Christoph Heiss wrote: > Thanks for the review & testing! > > On Wed, Aug 07, 2024 at 11:23:55AM GMT, Lukas Wagner wrote: > > [..] > > I found that once you select PAM again and log in as root, the PAM realm will > > be selected on next login again (even though 'save user' is not selected). > > This seems to happen because the ext-pbs-pveloginrealm:"o%3Avalue%3Ds%253Apam" > > key is set in local storage. If that one is cleared, it works again. > > So it seems like we are interfering with the statefulness of the login widget. > > > > Could you check if you can reproduce that? > > Also, thanks for the investigation! I'll check if I can reproduce it, > the fix for it seems to be doable in a sensible way by clearing the key. > Following up on this: PVE has the exact same behaviour. The login dialog component (`Proxmox.form.RealmComboBox`, living in proxmox-widget-toolkit) is in fact reused between both frontends. PVE uses the key `ext-pveloginrealm` in local storage, PBS `ext-pbs-pveloginrealm`. So IMHO either we should keep the behaviour as-is or change it for both, the latter preferably as a separate changeset. I would even argue to keep the behaviour, since it makes sense to me - if a user once logs in using a specific realm, he will probably want to *always* log in with that realm. What do you think? _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel