From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id F35A81FF16B
	for <inbox@lore.proxmox.com>; Thu, 20 Feb 2025 16:35:58 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 84D9D17136;
	Thu, 20 Feb 2025 16:35:53 +0100 (CET)
Date: Thu, 20 Feb 2025 16:35:21 +0100
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>
Message-ID: <jkqhjqe7rwexrbe3dyo3k7t26bjvyvscvqavhk7krxynhlbtev@euakwohmho5i>
References: <20250220153136.541754-1-g.goller@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250220153136.541754-1-g.goller@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.082 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup] cargo: add pbs-api-types
 override and reorder overrides
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

On Thu, Feb 20, 2025 at 04:31:36PM +0100, Gabriel Goller wrote:
> Add the new pbs-api-types crate to the cargo override section. Reorder
> the overrides to be alphabetic.
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  Cargo.toml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Cargo.toml b/Cargo.toml
> index 062de7cfb989..427e3e2d57e8 100644
> --- a/Cargo.toml
> +++ b/Cargo.toml
> @@ -253,7 +253,7 @@ proxmox-rrd-api-types.workspace = true
>  # Local path overrides
>  # NOTE: You must run `cargo update` after changing this for it to take effect!
>  [patch.crates-io]
> -
> +#proxmox-acme = { path = "../proxmox/proxmox-acme" }
>  #proxmox-apt = { path = "../proxmox/proxmox-apt" }
>  #proxmox-apt-api-types = { path = "../proxmox/proxmox-apt-api-types" }
>  #proxmox-async = { path = "../proxmox/proxmox-async" }
> @@ -289,8 +289,8 @@ proxmox-rrd-api-types.workspace = true
>  #proxmox-uuid = { path = "../proxmox/proxmox-uuid" }
>  #proxmox-worker-task = { path = "../proxmox/proxmox-worker-task" }
>  
> -#proxmox-acme = { path = "../proxmox/proxmox-acme" }
>  #pathpatterns = {path = "../pathpatterns" }
> +#pbs-api-types = { path = "../proxmox/pbs-api-types" }

While the name looks different, given that overrides need to be enabled
as complete workspaces I'd argue this line should be in the proxmox.git
block above.

>  #pxar = { path = "../pxar" }
>  
>  [features]
> -- 
> 2.39.5


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel