From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E49341FF38E for ; Tue, 11 Jun 2024 15:07:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D6AFF373E8; Tue, 11 Jun 2024 15:08:01 +0200 (CEST) Date: Tue, 11 Jun 2024 15:07:27 +0200 From: Wolfgang Bumiller To: Shannon Sterz Message-ID: References: <20240610154214.356689-1-s.sterz@proxmox.com> <20240610154214.356689-5-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240610154214.356689-5-s.sterz@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.093 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox 4/5] access: factor out user config and cache handling X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Mon, Jun 10, 2024 at 05:42:13PM GMT, Shannon Sterz wrote: > this commit factors out the user config as well as the shared memory > based config version caching mechanism. this makes it necessary that > users of this crate provide the product name and a reference to a > shared memory location as well. Given that we have more values in the shared memory in PBS I wonder if we should instead provide the `get` and `increment` methods to init (directly as `fn` or via a trait). _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel