From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9633A1FF15E for ; Fri, 23 Aug 2024 12:23:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 75BD5D9AF; Fri, 23 Aug 2024 12:23:45 +0200 (CEST) Date: Fri, 23 Aug 2024 12:23:13 +0200 From: Christoph Heiss To: Hannes Laimer Message-ID: References: <20240816111648.483368-1-c.heiss@proxmox.com> <20240816111648.483368-4-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH widget-toolkit v3 03/14] window: add panel for editing simple, built-in realms X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Fri, Aug 23, 2024 at 08:41:06AM GMT, Hannes Laimer wrote: > On Thu Aug 22, 2024 at 5:19 PM CEST, Christoph Heiss wrote: > > On Mon, Aug 19, 2024 at 04:18:54PM GMT, Hannes Laimer wrote: > > > On Fri Aug 16, 2024 at 1:16 PM CEST, Christoph Heiss wrote: > > > > Signed-off-by: Christoph Heiss > > > > [..] > > > > diff --git a/src/window/AuthEditSimple.js b/src/window/AuthEditSimple.js > > > > new file mode 100644 > > > > index 0000000..22932c0 > > > > --- /dev/null > > > > +++ b/src/window/AuthEditSimple.js > > > > @@ -0,0 +1,41 @@ > > > > [..] > > > > + { > > > > + xtype: 'proxmoxcheckbox', > > > > + fieldLabel: gettext('Default realm'), > > > > + name: 'default', > > > > + value: 0, > > > > > > nit: > > > this should include > > > ``` > > > cbind: { > > > deleteEmpty: '{!isCreate}' > > > }, > > > ``` > > > IIRC we don't send false, so it works because we PUT, but still > > > > > > > Since this panel is only used for built-in/pre-exisiting realms and no > > new "simple" realms can be created, `isCreate` does not exist anyway. > > > ohh, right, but then just `deleteEmpty: true` without the cbind, no? Sure, that makes sense. Just for completeness-sake - it works like this too, since the API accepts an `Option` for the `default` property - so if it's simply missing from the request, the outcome is the same. But setting `deleteEmpty` definitely makes the intent clearer to the reader. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel