From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 128459015 for ; Fri, 23 Jun 2023 12:07:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E7BF3327B5 for ; Fri, 23 Jun 2023 12:07:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 23 Jun 2023 12:07:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2F9134304D for ; Fri, 23 Jun 2023 12:07:08 +0200 (CEST) Date: Fri, 23 Jun 2023 12:07:07 +0200 From: Wolfgang Bumiller To: Maximiliano Sandoval Cc: pbs-devel@lists.proxmox.com Message-ID: References: <20230616082731.45647-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230616082731.45647-1-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.123 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [jobstate.rs, plugin.rs, tfa.rs, zfs.rs, acme.rs, drive.rs, restore.rs, datastore.rs, services.rs, mod.rs, auth.rs] Subject: [pbs-devel] applied-series: [PATCH v2 backup 0/5] Clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2023 10:07:09 -0000 applied series, thanks On Fri, Jun 16, 2023 at 10:27:26AM +0200, Maximiliano Sandoval wrote: > Differences from v1: > > - Rebased on top of master > - Changed prefix to backup > - Added space in commits between description and signed by > - Changed commit descriptions to include the "Why is it bad" blurb instead of > the URL, with the exception of the self-explanatory cast to i64 > > Maximiliano Sandoval (5): > clippy fixes: the borrowed expression implements the required traits > clippy fixes: use of ok_or followed by a function call > clippy fixes: casting to the same type is unnecessary > clippy fixes: Box::new(_) of default value > clippy fixes: deref which would be done by auto-deref > > src/acme/plugin.rs | 2 +- > src/api2/admin/datastore.rs | 2 +- > src/api2/config/acme.rs | 4 ++-- > src/api2/node/services.rs | 4 +++- > src/api2/tape/drive.rs | 2 +- > src/api2/tape/restore.rs | 2 +- > src/auth.rs | 6 +++--- > src/config/mod.rs | 4 ++-- > src/config/tfa.rs | 2 +- > src/server/jobstate.rs | 2 +- > src/tape/drive/virtual_tape.rs | 8 ++++---- > src/tape/encryption_keys.rs | 2 +- > src/tape/media_catalog.rs | 2 +- > src/tape/media_pool.rs | 4 +--- > src/tools/disks/mod.rs | 2 +- > src/tools/disks/zfs.rs | 2 +- > 16 files changed, 25 insertions(+), 25 deletions(-) > > -- > 2.39.2