From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BF6E51FF13C for ; Thu, 19 Mar 2026 11:57:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EE3161ADB6; Thu, 19 Mar 2026 11:57:16 +0100 (CET) Date: Thu, 19 Mar 2026 11:56:40 +0100 From: Arthur Bied-Charreton To: Shannon Sterz Subject: superseded [PATCH] fix #7337: Keep track of deep link on OpenID login Message-ID: References: <20260312143032.409115-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773917759439 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.869 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VQ3VW2ZZLSBXC6QACO2IAZ5LKUM6YYP6 X-Message-ID-Hash: VQ3VW2ZZLSBXC6QACO2IAZ5LKUM6YYP6 X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Mar 19, 2026 at 11:05:37AM +0100, Shannon Sterz wrote: > On Thu Mar 12, 2026 at 3:30 PM CET, Arthur Bied-Charreton wrote: > > Previously, when opening a deep link without being logged into PBS, the > > hash was getting lost, redirecting the user to #pbsDashboard instead of > > /#. > > > > Store `window.location.hash` in sessionStorage (per-tab storage) before > > redirecting to the login URL, and add it to the history after successful > > login to direct the user to the deeplink they opened. > > > > `#pbsDashboard` remains the default redirect if no deeplink is stored. > > > > Signed-off-by: Arthur Bied-Charreton > > --- > > www/LoginView.js | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/www/LoginView.js b/www/LoginView.js > > index fd9594f6..b72e4223 100644 > > --- a/www/LoginView.js > > +++ b/www/LoginView.js > > @@ -48,6 +48,7 @@ Ext.define('PBS.LoginView', { > > > > if (this.getViewModel().data.openid === true) { > > const redirectURL = location.origin; > > + sessionStorage.setItem('openid-deeplink', location.hash); > > nit: i think it would be nicer if this was prefixed, so something like > "pbs-openid-deeplink". also quickly grep-ing over the widget toolkit and > pbs ui directory, it seems that for local storage we tend to prefer > camel case, though that isn't consistent. > Ack, thanks for the suggestion! Added in v2: superseded by: https://lore.proxmox.com/pbs-devel/20260319105507.266484-1-a.bied-charreton@proxmox.com/T/#u