From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2 1/2] api: avoid retrieving lsblk result twice
Date: Tue, 12 Nov 2024 21:18:51 +0100 [thread overview]
Message-ID: <ff8f9de4-303a-4e17-b338-700f62e24775@proxmox.com> (raw)
In-Reply-To: <20240917080550.51803-1-g.goller@proxmox.com>
Am 17.09.24 um 10:05 schrieb Gabriel Goller:
> Avoid running `lsblk` twice when executing the `list_disk`
> endpoint/command. This and the various other small nits improve the
> performance of the endpoint.
>
> Does not really fix, but is related to: #4961.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>
> v2:
> - nothing
>
> src/api2/node/disks/mod.rs | 6 +++++-
> src/tools/disks/mod.rs | 10 +++++++---
> src/tools/disks/smart.rs | 10 +++-------
> src/tools/disks/zfs.rs | 15 ++++++++-------
> src/tools/disks/zpool_list.rs | 2 +-
> 5 files changed, 24 insertions(+), 19 deletions(-)
>
>
applied series, thanks!
While parallelism can also cause issues (load), this should be fine here and
it's only an implementation detail, so we always can change this back without
much hassle anyway.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-12 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 8:05 [pbs-devel] " Gabriel Goller
2024-09-17 8:05 ` [pbs-devel] [PATCH proxmox-backup v2 2/2] api: parallelize smartctl checks Gabriel Goller
2024-11-12 20:18 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff8f9de4-303a-4e17-b338-700f62e24775@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox