From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A97771FF56B for ; Mon, 22 Apr 2024 16:32:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4D3A514669; Mon, 22 Apr 2024 16:32:15 +0200 (CEST) Message-ID: Date: Mon, 22 Apr 2024 16:32:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Lukas Wagner References: <20240422123841.280675-1-l.wagner@proxmox.com> <20240422123841.280675-29-l.wagner@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20240422123841.280675-29-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v4 28/43] ui: tape backup job: add selector for notification-mode X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" question do we really want to add --- notification-mode notification-system --- to every new job config/api call? since it seems to be the default when none is set, couldn't we just leave it out of the config (at least when setting from the gui?) comment inline: both the question and comment is valid for the next patches too On 4/22/24 14:38, Lukas Wagner wrote: > Signed-off-by: Lukas Wagner > Tested-by: Gabriel Goller > Reviewed-by: Gabriel Goller > --- > www/tape/window/TapeBackupJob.js | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/www/tape/window/TapeBackupJob.js b/www/tape/window/TapeBackupJob.js > index abbbaa0b..309dda0b 100644 > --- a/www/tape/window/TapeBackupJob.js > +++ b/www/tape/window/TapeBackupJob.js > @@ -46,6 +46,15 @@ Ext.define('PBS.TapeManagement.BackupJobEdit', { > }, > }, > > + viewModel: { > + data: { > + notificationMode: 'notification-system', > + }, > + formulas: { > + notificationSystemSelected: (get) => get('notificationMode') === 'notification-system', > + }, > + }, > + > items: { > xtype: 'tabpanel', > bodyPadding: 10, > @@ -109,6 +118,18 @@ Ext.define('PBS.TapeManagement.BackupJobEdit', { > fieldLabel: gettext('Drive'), > name: 'drive', > }, > + { > + xtype: 'proxmoxKVComboBox', > + comboItems: [ > + ['legacy-sendmail', gettext('Email (legacy)')], > + ['notification-system', gettext('Notification system')], > + ], > + fieldLabel: gettext('Notification mode'), > + name: 'notification-mode', > + bind: { > + value: '{notificationMode}', > + }, if you do this, an edit on an entry where no value is set will enable the 'reset' button and reset the field to the empty value normally we use '__default__' to represent this default value (and set it by default too) > + }, > { > xtype: 'pmxUserSelector', > name: 'notify-user', > @@ -117,6 +138,9 @@ Ext.define('PBS.TapeManagement.BackupJobEdit', { > allowBlank: true, > value: null, > renderer: Ext.String.htmlEncode, > + bind: { > + disabled: "{notificationSystemSelected}", > + }, > }, > ], > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel