From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 57254F518 for ; Fri, 29 Sep 2023 12:24:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2DE7A1F199 for ; Fri, 29 Sep 2023 12:23:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 29 Sep 2023 12:23:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D590044668; Fri, 29 Sep 2023 12:23:47 +0200 (CEST) Message-ID: Date: Fri, 29 Sep 2023 12:23:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Wolfgang Bumiller Cc: Proxmox Backup Server development discussion , Gabriel Goller , Thomas Lamprecht References: <20230821111938.110298-1-g.goller@proxmox.com> From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: Outsource the logger initialization to the router X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2023 10:24:19 -0000 On 9/29/23 11:49, Wolfgang Bumiller wrote: > On Fri, Sep 29, 2023 at 11:35:06AM +0200, Dominik Csapak wrote: > `proxmox-router` - the CLI tools definitely won't want to pull in > `proxmox-rest-server`, so moving the cli logger setup there doesn't make > sense. just fyi on that, the `proxmox-backup-manager` already depends on the rest-server, but i don't know if that qualifies for your definition of 'CLI tool' (well it is, but not at the client side) basically everything that interacts with workers now must depend on that (maybe we should factor the workertask stuff out from the rest server?)