From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 621E3D77D for ; Mon, 21 Aug 2023 13:20:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4BD66165D1 for ; Mon, 21 Aug 2023 13:20:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 21 Aug 2023 13:20:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8A4E942BFB for ; Mon, 21 Aug 2023 13:20:35 +0200 (CEST) Message-ID: Date: Mon, 21 Aug 2023 13:20:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: Wolfgang Bumiller Cc: pbs-devel@lists.proxmox.com References: <20230807125737.168352-1-g.goller@proxmox.com> <7g7uon2zdpu5jyomd7o2cu3wqwatsxszvrlz4e5k2eo6wr56t6@oumy5xgaoz3s> From: Gabriel Goller In-Reply-To: <7g7uon2zdpu5jyomd7o2cu3wqwatsxszvrlz4e5k2eo6wr56t6@oumy5xgaoz3s> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.704 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -4.279 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4646: Set BackupReader debug to current loglevel X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2023 11:20:36 -0000 Submitted a patch with the proposed change. On 8/17/23 14:42, Wolfgang Bumiller wrote: > On Fri, Aug 11, 2023 at 02:53:17PM +0200, Gabriel Goller wrote: >> On a second note, how about we also introduce more fine-grained logging >> settings to the api/proxy? >> Currently on the api we hardcode the `log::max_level` to `LevelFilter::Info` >> and on the proxy we check >> if the environment variable `PROXMOX_DEBUG` is set and use >> `LevelFilter::Debug` if it exists. We could >> do the same as on the cli and allow `PROXMOX_DEBUG` (probably renaming it to >> `PROXMOX_LOG_LEVEL` >> or something) to be set to `trace`, `debug`, `info`, `warning` or `error`. >> Then we could also decide if we want to use the server `log::max_level` or >> the client-side `debug` flag in >> the `download_file` and `download_chunk` functions (where the original issue >> #4646 comes from). > A while ago we Hannes added `init_cli_logger` to proxmox-router which > the CLI binaries call with the `$PBS_LOG` env var. > Having the same mechanism for the daemons' log levels would probably > make sense. We should probably also call it PBS_LOG then. > People could probably temporarily change it via `systemctl > set-environment` or more permanently via an `Environment=` systemd > service snippet file.