From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0498F1FF13B for ; Wed, 06 May 2026 17:13:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D4372257C3; Wed, 6 May 2026 17:13:09 +0200 (CEST) Message-ID: Date: Wed, 6 May 2026 17:13:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup v2 4/5] ui: datastore: disable remove action for namespaces To: Erik Fastermann , pbs-devel@lists.proxmox.com References: <20260506121332.21896-1-e.fastermann@proxmox.com> <20260506121332.21896-5-e.fastermann@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260506121332.21896-5-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778080279591 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JFAEEVPW4AOZ3VOIV7LY23RCSLLY4W7O X-Message-ID-Hash: JFAEEVPW4AOZ3VOIV7LY23RCSLLY4W7O X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/6/26 2:12 PM, Erik Fastermann wrote: > Disable the remove action and tooltip for namespaces. nit: a short 'why' would improve the commit message here for example: Since the namespace entry does not show a remove button, also disable the action itself and hide the tooltip. > > Signed-off-by: Erik Fastermann > --- > > changes since v1: > * cleaned up boolean logic > > www/datastore/Content.js | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/www/datastore/Content.js b/www/datastore/Content.js > index cb0159a51..576e70a59 100644 > --- a/www/datastore/Content.js > +++ b/www/datastore/Content.js > @@ -1211,7 +1211,13 @@ Ext.define('PBS.DataStoreContent', { > data.ty === 'dir' > ? 'fa critical fa-trash-o' > : 'pmx-hidden', > - isActionDisabled: (v, r, c, i, { data }) => false, > + isActionDisabled: (v, r, c, i, { data }) => { > + const enabled = > + (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) || > + data.ty === 'group' || > + data.ty === 'dir'; > + return !enabled; > + }, > }, > { > handler: 'downloadFile',