From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7C1521FF173 for ; Mon, 25 Nov 2024 14:06:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F977130D8; Mon, 25 Nov 2024 14:06:17 +0100 (CET) Message-ID: Date: Mon, 25 Nov 2024 14:06:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Hannes Laimer References: <20241122144713.299130-17-h.laimer@proxmox.com> <20241125084752.28727-1-h.laimer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20241125084752.28727-1-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v14] fixup! ui: tree: render unmounted datastores correctly X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" one comment inline On 11/25/24 09:47, Hannes Laimer wrote: > --- > fixes small problem with the original patch where all datastores were rendered with the plug > icon in the UI > > sent in reply to original patch since it is a really minor or change and > can just be squashed in > www/NavigationTree.js | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/www/NavigationTree.js b/www/NavigationTree.js > index dd03fbd62..29ecae7fe 100644 > --- a/www/NavigationTree.js > +++ b/www/NavigationTree.js > @@ -266,7 +266,8 @@ Ext.define('PBS.view.main.NavigationTree', { > while (name.localeCompare(getChildTextAt(j)) > 0 && (j+1) < list.childNodes.length) { > j++; > } > - let mainIcon = `fa fa-${records[i].data.mount-status !== 'nonremovable' ? 'plug' : 'database'}`; > + const isRemovable = records[i].data['mount-status'] !== 'nonremovable'; > + let mainIcon = `fa fa-${isRemovable ? 'plug' : 'database'}`; i think it'll not happen, but if an 'old' api returns no 'mount-status' at all, i think we should default to the 'normal' symbol, not the plug one so e.g. let mountStatus = records[i].data['mount-status'] ?? 'nonremovable'; let isRemoveable = mountStatus !== 'nonremovable'; or something like this > let [qtip, iconCls] = ['', mainIcon]; > const maintenance = records[i].data.maintenance; > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel