From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 9E3A11FF15E
for <inbox@lore.proxmox.com>; Tue, 8 Apr 2025 16:22:06 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id A34521F67C;
Tue, 8 Apr 2025 16:22:03 +0200 (CEST)
Message-ID: <f8dbd4bc-294c-47e8-9ecc-923ee548cf44@proxmox.com>
Date: Tue, 8 Apr 2025 16:21:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
References: <20250408123811.178716-1-c.ebner@proxmox.com>
<20250408123811.178716-2-c.ebner@proxmox.com>
<e72lwy5ajpmvq36hqo4egzvbg47i5wu3o7amehtitw7myu3ryv@xvhz2igtj3iw>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <e72lwy5ajpmvq36hqo4egzvbg47i5wu3o7amehtitw7myu3ryv@xvhz2igtj3iw>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.030 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH v3 proxmox 1/4] http: client: make https
connector generic over resolver
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On 4/8/25 16:06, Wolfgang Bumiller wrote:
> One tiny nit...
>
> On Tue, Apr 08, 2025 at 02:38:08PM +0200, Christian Ebner wrote:
>>
>> #[derive(Clone)]
>> -pub struct HttpsConnector {
>> - connector: HttpConnector,
>> +pub struct HttpsConnector<T> {
>
> Generics on structs can have defaults, so if we use
>
> struct HttpsConnctor<T = GaiResolver> {}
>
> then even the old pbs code builds.
> While it is *still* technically a breaking change, other users of this
> crate *likely* can do with just a dependency bump.
>
> (But at least it *sort of* documents what the heck this `T` is supposed
> to be on a type otherwise completely devoid of documentation ;-) )
A great! Will add the default type for the generic and add the docs as
requested by Lukas in the other response.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel