From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F250B95853 for ; Fri, 12 Apr 2024 16:09:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D28AFBA9B for ; Fri, 12 Apr 2024 16:09:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Apr 2024 16:09:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1B8D245082 for ; Fri, 12 Apr 2024 16:09:45 +0200 (CEST) Message-ID: Date: Fri, 12 Apr 2024 16:09:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Gabriel Goller References: <20240412100631.94218-1-l.wagner@proxmox.com> Content-Language: en-US From: Lukas Wagner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup 00/33] integrate notification system X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2024 14:09:47 -0000 Hey! Thanks a lot for this first round of feedback! On 12.04.24 15:59, Gabriel Goller wrote: > First of all, thanks for implementing this! I can't count how many times > I've seen a forum post asking for better notifications in pbs! > > Some high-level comments: > - The 'hostname' field doesn't make any sense in pbs (AFAICT) because > there is only one node. Right, we might just kick that out then. > - The 'type' field could have hardcoded values, such as 'gc', 'verify', > etc. this way we can also have a drop-down menu in the ui. This makes > it a lot easier than checking the docs/guessing. If you apply/deploy the `proxmox-widget-toolkit` patches from https://lists.proxmox.com/pipermail/pve-devel/2024-February/061992.html then you should automatically get an improved UI for creating matchers where one can select from known types and other metadata values. :) > - A notification when a backup succeeds/fails would be very useful as > well. For now I have just ported the existing notifications - new ones can of course be added later :) > - Also having datastore and namespace filters on the notification > matchers would be great (if feasible obv.). Matching on datastores should also work already with the WTK-patches mentioned above > > > Another thing I noticed is that creating a datastore through the cli > still uses the legacy notification system. > Ah, thx! > Will make a more in depth review next week! > Greatly appreciated!