From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E4A951FF165 for ; Thu, 6 Nov 2025 18:43:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9777A1E8E7; Thu, 6 Nov 2025 18:44:10 +0100 (CET) Message-ID: Date: Thu, 6 Nov 2025 18:44:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Nicolas Frey References: <20251106161316.528349-1-n.frey@proxmox.com> <20251106161316.528349-3-n.frey@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251106161316.528349-3-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762451027054 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v2 2/3] pbs-api-types: jobs: add {read, verify}-threads to VerificationJobConfig X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Am 06.11.25 um 17:13 schrieb Nicolas Frey: > controls the number of parallel threads to read/verify chunks. > Any thoughts on having these options (also) in the datastore config's tuning options? No hard feelings for that, just something I asked myself. Can be fine to not do now (it's easier to add things later than having to remove them again), but might still warrant adding some reasoning for choosing the verification config here in the commit message, at least if there's the need for a v3. Could be fleeced in on applying otherwise. > Signed-off-by: Nicolas Frey > --- > pbs-api-types/src/jobs.rs | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/pbs-api-types/src/jobs.rs b/pbs-api-types/src/jobs.rs > index 4dbbef2b..2b9cef38 100644 > --- a/pbs-api-types/src/jobs.rs > +++ b/pbs-api-types/src/jobs.rs > @@ -203,6 +203,14 @@ pub const VERIFICATION_OUTDATED_AFTER_SCHEMA: Schema = > optional: true, > schema: crate::NS_MAX_DEPTH_SCHEMA, > }, > + "read-threads": { > + schema: crate::READ_THREADS_SCHEMA, > + optional: true, > + }, > + "verify-threads": { > + schema: crate::VERIFY_THREADS_SCHEMA, > + optional: true, > + }, > } > )] > #[derive(Serialize, Deserialize, Updater, Clone, PartialEq)] > @@ -233,6 +241,12 @@ pub struct VerificationJobConfig { > /// how deep the verify should go from the `ns` level downwards. Passing 0 verifies only the > /// snapshots on the same level as the passed `ns`, or the datastore root if none. > pub max_depth: Option, > + /// The number of read threads to use for the job. > + #[serde(skip_serializing_if = "Option::is_none")] > + pub read_threads: Option, > + /// The number of verification threads to use for the job. > + #[serde(skip_serializing_if = "Option::is_none")] > + pub verify_threads: Option, > } > > impl VerificationJobConfig { _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel