From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B19639160A for ; Thu, 4 Apr 2024 11:11:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B06E34F1B for ; Thu, 4 Apr 2024 11:10:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 4 Apr 2024 11:10:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D0C3844EE1 for ; Thu, 4 Apr 2024 11:10:28 +0200 (CEST) Message-ID: Date: Thu, 4 Apr 2024 11:10:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Ebner To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= Reply-To: Proxmox Backup Server development discussion References: <20240328123707.336951-1-c.ebner@proxmox.com> <20240328123707.336951-25-c.ebner@proxmox.com> <1712221270.omwan9hcjc.astroid@yuna.none> <5c88bec5-4ccc-403e-b464-41e5cc163d2f@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: <5c88bec5-4ccc-403e-b464-41e5cc163d2f@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 24/58] tools: cover meta extension for pxar archives X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2024 09:11:02 -0000 On 4/4/24 11:06, Christian Ebner wrote: > On 4/4/24 11:01, Fabian Grünbichler wrote: >> On March 28, 2024 1:36 pm, Christian Ebner wrote: >>> Signed-off-by: Christian Ebner >>> --- >>> changes since version 2: >>> - use mpxar and ppxar file extensions >>> >>>   pbs-client/src/tools/mod.rs | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/pbs-client/src/tools/mod.rs b/pbs-client/src/tools/mod.rs >>> index 1b0123a39..08986fc5e 100644 >>> --- a/pbs-client/src/tools/mod.rs >>> +++ b/pbs-client/src/tools/mod.rs >>> @@ -337,7 +337,7 @@ pub fn complete_pxar_archive_name(arg: &str, >>> param: &HashMap) -> >>>       complete_server_file_name(arg, param) >>>           .iter() >>>           .filter_map(|name| { >>> -            if name.ends_with(".pxar.didx") { >>> +            if name.ends_with(".pxar.didx") || >>> name.ends_with(".pxar.meta.didx") { >> >> this still has the old extension/naming scheme instead of the new one > > Oh, thanks for noticing! Fixed it right away in the new version branch! Actually, it already is fixed in a followup patch, fixed the patches