From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6396A1FF16E for <inbox@lore.proxmox.com>; Mon, 28 Apr 2025 10:48:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CB3B1C851; Mon, 28 Apr 2025 10:49:05 +0200 (CEST) Message-ID: <f5b1c6ec-72c7-4748-80a6-08b07fc03570@proxmox.com> Date: Mon, 28 Apr 2025 10:49:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> References: <20250418103849.194119-1-c.ebner@proxmox.com> <77cff8da-3125-4e9d-a524-6b59b1691083@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner <c.ebner@proxmox.com> In-Reply-To: <77cff8da-3125-4e9d-a524-6b59b1691083@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox] acme: directory: make non-required url fields optional X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> On 4/22/25 10:03, Thomas Lamprecht wrote: > Am 18.04.25 um 12:38 schrieb Christian Ebner: >> ACME servers provide the directory endpoint for clients to discover >> the URLs for ACME operation. These fields are described in RFC 8555 >> [0], but section 7.1 of the corresponding RFC [1] states that the >> server is only required to provide the `directory` and `newNonce` >> resources. >> >> Therefore, make the not explicitly required fields optional to not >> fail during deserialization of the json response and improve error >> handling when the acme client actually requires the not-provided >> operation url. >> >> This was discovered based on issues reported in the community forum. > > What about the perl implementation in PVE/PMG, or is that not affected > of this issue? The Perl implementation is not affected, as [0] already handles URLs as optional and only fails if an URL for a requested operation does not exist. This has also been confirmed by the users in the forum, mentioning that the same acme provider works without issues on Proxmox VE [1]. [0] https://git.proxmox.com/?p=proxmox-acme.git;a=blob;f=src/PVE/ACME.pm;h=65094c20d1707f99e2e47e8576885db89f44aee4;hb=HEAD#l286 [1] https://forum.proxmox.com/threads/159987/post-735018 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel