From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1F116966EE for ; Tue, 16 Apr 2024 10:58:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EC6EF1694B for ; Tue, 16 Apr 2024 10:57:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 16 Apr 2024 10:57:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7401644FB7 for ; Tue, 16 Apr 2024 10:57:28 +0200 (CEST) Message-ID: Date: Tue, 16 Apr 2024 10:57:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Hannes Laimer References: <20240409110012.166472-1-h.laimer@proxmox.com> <20240409110012.166472-17-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20240409110012.166472-17-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 16/24] ui: add partition selector form X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2024 08:58:00 -0000 a comment inline On 4/9/24 13:00, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > www/Makefile | 1 + > www/form/PartitionSelector.js | 59 +++++++++++++++++++++++++++++++++++ > 2 files changed, 60 insertions(+) > create mode 100644 www/form/PartitionSelector.js > > diff --git a/www/Makefile b/www/Makefile > index 79cb4c04..762d90c5 100644 > --- a/www/Makefile > +++ b/www/Makefile > @@ -49,6 +49,7 @@ JSSRC= \ > form/NamespaceMaxDepth.js \ > form/CalendarEvent.js \ > form/PermissionPathSelector.js \ > + form/PartitionSelector.js \ > form/GroupSelector.js \ > form/GroupFilter.js \ > form/VerifyOutdatedAfter.js \ > diff --git a/www/form/PartitionSelector.js b/www/form/PartitionSelector.js > new file mode 100644 > index 00000000..64e7990a > --- /dev/null > +++ b/www/form/PartitionSelector.js > @@ -0,0 +1,59 @@ > +Ext.define('pbs-partition-list', { > + extend: 'Ext.data.Model', > + fields: ['name', 'uuid', 'filesystem', 'devpath', 'size'], > + proxy: { > + type: 'proxmox', > + url: "/api2/json/nodes/localhost/disks/list?include-partitions=1&only-unused=1", without setting the `skipsmart` flag you fetch also the smart stats, not used however, so you might set this. > + reader: { > + transform: (rawData) => rawData.data > + .flatMap(disk => (disk.partitions ?? []) > + .filter(partition => partition.used === 'filesystem')), > + }, > + }, > + idProperty: 'devpath', > + > +}); > + > +Ext.define('PBS.form.PartitionSelector', { > + extend: 'Proxmox.form.ComboGrid', > + alias: 'widget.pbsPartitionSelector', > + > + allowBlank: false, > + autoSelect: false, > + valueField: 'uuid', > + displayField: 'devpath', > + > + store: { > + model: 'pbs-partition-list', > + autoLoad: true, > + sorters: 'devpath', > + }, > + > + listConfig: { > + columns: [ > + { > + header: gettext('Path'), > + sortable: true, > + dataIndex: 'devpath', > + renderer: (v, metaData, rec) => Ext.String.htmlEncode(v), > + flex: 1, > + }, > + { > + header: gettext('Filesystem'), > + sortable: true, > + dataIndex: 'filesystem', > + flex: 1, > + }, > + { > + header: gettext('Size'), > + sortable: true, > + dataIndex: 'size', > + renderer: Proxmox.Utils.format_size, > + flex: 1, > + }, > + ], > + viewConfig: { > + emptyText: 'No partitions present', > + }, > + }, > +});