From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 29C7BB95C4
for <pbs-devel@lists.proxmox.com>; Thu, 14 Mar 2024 09:01:59 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0B95C86B2
for <pbs-devel@lists.proxmox.com>; Thu, 14 Mar 2024 09:01:29 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Thu, 14 Mar 2024 09:01:24 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9DA8946FC9;
Thu, 14 Mar 2024 09:01:24 +0100 (CET)
Message-ID: <f463e77b-2285-4037-8567-efac001b33e7@proxmox.com>
Date: Thu, 14 Mar 2024 09:01:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Gabriel Goller <g.goller@proxmox.com>
References: <20240313161801.132483-1-g.goller@proxmox.com>
<20240313161801.132483-2-g.goller@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20240313161801.132483-2-g.goller@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.019 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] fix #5188: gui: add copy
to clipboard on snapshots
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 14 Mar 2024 08:01:59 -0000
same comment as the previous patch, some note about why async is
ok would be nice
one high level comment:
i'd probably rename the button from 'copy' to something like 'copy name to clipboard'
otherwise it can be confusing as to what the button does, since 'copy' could
also mean duplicate the snapshot ;)
rest of the patch LGTM
On 3/13/24 17:17, Gabriel Goller wrote:
> When navigating to Datastores -> Content, it is now possible to
> right-click on a snapshot/group and copy the name to the clipboard.
> This makes the proxmox-backup-client much easier to use, especially when
> restoring archives.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> www/datastore/Content.js | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index fa0b7d2c..b2d6a053 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -546,6 +546,10 @@ Ext.define('PBS.DataStoreContent', {
> });
> },
>
> + onCopy: async function(view, rI, cI, item, e, { data }) {
> + await navigator.clipboard.writeText(data.text);
> + },
> +
> onNotesEdit: function(view, data) {
> let me = this;
>
> @@ -884,6 +888,7 @@ Ext.define('PBS.DataStoreContent', {
> if (record.data.ty === 'group') {
> menu = Ext.create('PBS.datastore.GroupCmdMenu', {
> title: gettext('Group'),
> + onCopy: createControllerCallback('onCopy'),
> onVerify: createControllerCallback('onVerify'),
> onChangeOwner: createControllerCallback('onChangeOwner'),
> onPrune: createControllerCallback('onPrune'),
> @@ -892,6 +897,7 @@ Ext.define('PBS.DataStoreContent', {
> } else if (record.data.ty === 'dir') {
> menu = Ext.create('PBS.datastore.SnapshotCmdMenu', {
> title: gettext('Snapshot'),
> + onCopy: createControllerCallback('onCopy'),
> onVerify: createControllerCallback('onVerify'),
> onProtectionChange: createControllerCallback('onProtectionChange'),
> onForget: createControllerCallback('onForget'),
> @@ -1284,12 +1290,21 @@ Ext.define('PBS.datastore.GroupCmdMenu', {
> extend: 'Ext.menu.Menu',
> mixins: ['Proxmox.Mixin.CBind'],
>
> + onCopy: undefined,
> onVerify: undefined,
> onChangeOwner: undefined,
> onPrune: undefined,
> onForget: undefined,
>
> items: [
> + {
> + text: gettext('Copy'),
> + iconCls: 'fa fa-clipboard',
> + handler: function() { this.up('menu').onCopy(); },
> + cbind: {
> + hidden: '{!onCopy}',
> + },
> + },
> {
> text: gettext('Verify'),
> iconCls: 'pve-icon-verify-lettering',
> @@ -1330,11 +1345,21 @@ Ext.define('PBS.datastore.SnapshotCmdMenu', {
> extend: 'Ext.menu.Menu',
> mixins: ['Proxmox.Mixin.CBind'],
>
> + onCopy: undefined,
> onVerify: undefined,
> onProtectionChange: undefined,
> onForget: undefined,
>
> items: [
> + {
> + text: gettext('Copy'),
> + iconCls: 'fa fa-clipboard',
> + handler: function() { this.up('menu').onCopy(); },
> + cbind: {
> + hidden: '{!onCopy}',
> + disabled: '{!onCopy}',
> + },
> + },
> {
> text: gettext('Verify'),
> iconCls: 'pve-icon-verify-lettering',