From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0CE041FF141 for ; Tue, 05 May 2026 15:49:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E05C34358; Tue, 5 May 2026 15:49:23 +0200 (CEST) Message-ID: Date: Tue, 5 May 2026 15:48:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Ebner Subject: Re: [PATCH proxmox 2/3] pbs-abi-types: add GarbageCollection maintenance mode To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260430150607.330413-1-r.obkircher@proxmox.com> <20260430150607.330413-3-r.obkircher@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: <20260430150607.330413-3-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777988821030 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QXRPHULI5SP2WWAMTP6DLYVEZKURETKX X-Message-ID-Hash: QXRPHULI5SP2WWAMTP6DLYVEZKURETKX X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: typo in commit message s/pbs-abi-types/pbs-api-types/ also, one nit inline. On 4/30/26 5:04 PM, Robert Obkircher wrote: > This mode may be used to safely prune and garbage collect a datastore > without the risk of running out of space due to new backups. > > Signed-off-by: Robert Obkircher > --- > pbs-api-types/src/datastore.rs | 1 + > pbs-api-types/src/maintenance.rs | 8 ++++---- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs > index 098d2b7c..47ae1819 100644 > --- a/pbs-api-types/src/datastore.rs > +++ b/pbs-api-types/src/datastore.rs > @@ -635,6 +635,7 @@ impl DataStoreConfig { > > match current_type { > Some(MaintenanceType::ReadOnly) => { /* always OK */ } > + Some(MaintenanceType::GarbageCollection) => { /* always OK */ } > Some(MaintenanceType::Offline) => { /* always OK */ } > Some(MaintenanceType::Unmount) => { > /* used to reset it after failed unmount, or alternative for aborting unmount task */ > diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs > index 8a37756a..a46764bc 100644 > --- a/pbs-api-types/src/maintenance.rs > +++ b/pbs-api-types/src/maintenance.rs > @@ -42,12 +42,10 @@ pub enum Operation { > #[serde(rename_all = "kebab-case")] > /// Maintenance type. > pub enum MaintenanceType { > - // TODO: > - // - Add "GarbageCollection" or "DeleteOnly" as type and track GC (or all deletes) as separate > - // operation, so that one can enable a mode where nothing new can be added but stuff can be > - // cleaned > /// Only read operations are allowed on the datastore. > ReadOnly, > + /// Allow reads and reclaim operations, but no new writes. > + GarbageCollection, > /// Neither read nor write operations are allowed on the datastore. > Offline, > /// The datastore is being deleted. > @@ -116,6 +114,8 @@ impl MaintenanceMode { > && matches!(operation, Operation::Write | Operation::Reclaim) > { > bail!("read-only maintenance mode: {}", message); > + } else if self.ty == MaintenanceType::GarbageCollection && operation == Operation::Write { > + bail!("garbage-collection maintenance mode: {}", message); nit: for new code we prefer variable names inline in the format string. Could be done as additional patch for the other, pre-existing occurrences here as well to bring them in line. > } > Ok(()) > }