From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 275781FF2A1 for ; Tue, 16 Jul 2024 10:38:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1EF1FEA04; Tue, 16 Jul 2024 10:38:59 +0200 (CEST) Message-ID: Date: Tue, 16 Jul 2024 10:38:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Ebner To: Proxmox Backup Server development discussion , Gabriel Goller References: <20240715151301.550787-1-g.goller@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] log: retrieve `ReaderEnvironment` debug flag from tracing X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/16/24 10:21, Christian Ebner wrote: > > This is indeed a bit odd: The fact that the client can set the `debug` > flag when upgrading to the backup protocol, but cannot and should not > control the filter level makes this a bit strange. > > So I would suggest to rename this method to something like > `client_debug` (or something better fitting?) an instead of calling the > `info` macro directly, call `self.log` instead if `self.debug` is set. > By this, it should at least be a bit more clear what is going on and one > cannot accidentally loose these debug messages as the same codepath is > then used for generating the event. > Forgot to mention that by having a `debug` and a `client_debug` method, it would also be possible to differentiate log events generated by client request and ones only by level set for the server. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel