From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B1B637B242 for ; Tue, 11 May 2021 18:12:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A4C852426B for ; Tue, 11 May 2021 18:12:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EC90A2425A for ; Tue, 11 May 2021 18:11:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B749042D90 for ; Tue, 11 May 2021 18:11:56 +0200 (CEST) Message-ID: Date: Tue, 11 May 2021 18:11:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Wolfgang Bumiller References: <20210511135400.32406-1-w.bumiller@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210511135400.32406-1-w.bumiller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.006 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [certificates.rs, proxmox-backup-proxy.rs, server.rs, config.rs] Subject: [pbs-devel] applied-series: [PATCH backup 0/7] hot-reload proxy certificates X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 16:12:00 -0000 On 11.05.21 15:53, Wolfgang Bumiller wrote: > This adds the ability to tell a running proxy to just reload the TLS > cert certificates via the command-socket. > > Starts off with some cleanup/refactoring to get rid of all that heavy > indentation... > > Wolfgang Bumiller (7): > proxy: factor out accept_connection > proxy: "continue on error" for the accept call, too > proxy: Arc usage cleanup > proxy: factor out tls acceptor creation > proxy: implement 'reload-certificate' command > refactor send_command > hot-reload proxy certificate when updating via the API > > src/api2/node/certificates.rs | 26 ++-- > src/bin/proxmox-backup-proxy.rs | 220 ++++++++++++++++++++------------ > src/config.rs | 17 +-- > src/server.rs | 9 ++ > src/server/command_socket.rs | 71 ++++++----- > src/server/worker_task.rs | 4 +- > 6 files changed, 204 insertions(+), 143 deletions(-) > applied whole series, thanks! I followed this up with: * fallback to "default" account on order (check commit message, was really confusing else) * add UI task-description entries for acme related tasks, mostly based on the ones from PVE, but as the worker type is spelled slightly different anyway here I took the chance to use a slightly nicer version there too. * set account name as worker ID so that they can be used in by the task-descriptions - note: all account actions done before that commit miss it and will display "default", even if the account was named something else, I ignored this as we did not really rolled this out externally yet.