From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C98A161014 for ; Fri, 11 Sep 2020 13:07:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B643C24194 for ; Fri, 11 Sep 2020 13:07:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 71DE424184 for ; Fri, 11 Sep 2020 13:07:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3BC2D44B61 for ; Fri, 11 Sep 2020 13:07:25 +0200 (CEST) To: pbs-devel@lists.proxmox.com References: <20200828084658.22057-1-h.laimer@proxmox.com> From: Dominik Csapak Message-ID: Date: Fri, 11 Sep 2020 13:07:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Thunderbird/81.0 MIME-Version: 1.0 In-Reply-To: <20200828084658.22057-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.363 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.576 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [directory.rs] Subject: Re: [pbs-devel] [PATCH v3 proxmox-widget-toolbox 0/9] removal of directories in PBS WebUI X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2020 11:07:26 -0000 On 8/28/20 10:46 AM, Hannes Laimer wrote: > Add functionality to remove directories in the PBS WebUI. In order to do that SafeDestroy had to be moved from > pve-manager into proxmox-widget-toolkit and the possibility to show a small note in the dialog had to be added. > Furthermore specifics to pve-manager in SafeRemove were replaces with a more general approach, namely: 'type' was > replaced with 'purgeable' and 'taskName'. Due to the moving and refactorization the usages of SafeDestroy in pve-manager > had to be corrected. In order to avoid the extraction of the directory name from the path in the frontend, the api2 > now also returns the name of a directory. > > proxmox-widget-toolkit needs a version bump, pve-manager and proxmox-backup require that new version. > > v3: - smaller patches with each doing a single thing > - correct indentation for JS files > > v2: - SafeRemove -> SafeDestroy (keep original name) > - generalized SafeDestroy > - fixed eslint related issues > - split patch [3/5]v1 into two patches > looks mostly ok, but i have some comments i'll reply to the separate patches for those > proxmox-widget-toolkit: Hannes Laimer (5): > safe-destroy: move here from pve-manager > safe-destroy: replace type with purgeable and taskName > safe-destroy: replace var with let/const > safe-destroy: add possibility to show a small note > utils: add task description for directory removal > > src/Makefile | 1 + > src/window/SafeDestroy.js | 210 ++++++++++++++++++++++++++++++++++++++ > src/Utils.js | 1 + > 3 files changed, 212 insertions(+) > create mode 100644 src/window/SafeDestroy.js > > pve-manager: Hannes Laimer (2): > safe-destroy: use SafeDestroy from proxmox-widget-toolkit > remove SafeDestroy from pve-manager > > www/manager6/Makefile | 1 - > www/manager6/ceph/Pool.js | 5 +- > www/manager6/lxc/Config.js | 5 +- > www/manager6/qemu/Config.js | 5 +- > www/manager6/storage/ContentView.js | 5 +- > www/manager6/window/SafeDestroy.js | 194 ---------------------------- > 6 files changed, 12 insertions(+), 203 deletions(-) > delete mode 100644 www/manager6/window/SafeDestroy.js > > proxmox-backup: Hannes Laimer (2): > api2: add name of mount-point to DatastoreMountInfo > ui: add remove-button for directories/mount-units > > src/api2/node/disks/directory.rs | 4 ++++ > www/DirectoryList.js | 25 +++++++++++++++++++++++++ > 2 files changed, 29 insertions(+) >