From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 71E9F1FF56B for ; Mon, 22 Apr 2024 11:28:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 61E53D16E; Mon, 22 Apr 2024 11:28:24 +0200 (CEST) Message-ID: Date: Mon, 22 Apr 2024 11:27:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Hannes Laimer References: <20240419155606.112010-1-h.laimer@proxmox.com> <20240419155606.112010-22-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20240419155606.112010-22-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v8 21/23] api: node: allow creation of removable datastore through directory endpoint X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" nits inline On 4/19/24 17:56, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > src/api2/node/disks/directory.rs | 67 +++++++++++++++++++++++++++++++- > 1 file changed, 65 insertions(+), 2 deletions(-) > > diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs > index 9f1112a9..a34ed676 100644 > --- a/src/api2/node/disks/directory.rs > +++ b/src/api2/node/disks/directory.rs > @@ -123,6 +123,11 @@ pub fn list_datastore_mounts() -> Result, Error> { > type: bool, > optional: true, > }, > + "removable-datastore": { > + description: "The the added datastore is removable.", > + type: bool, > + optional: true, > + }, > filesystem: { > type: FileSystemType, > optional: true, > @@ -136,11 +141,14 @@ pub fn list_datastore_mounts() -> Result, Error> { > permission: &Permission::Privilege(&["system", "disks"], PRIV_SYS_MODIFY, false), > }, > )] > -/// Create a Filesystem on an unused disk. Will be mounted under `/mnt/datastore/`. > +/// Create a Filesystem on an unused disk. Will be mounted under `/mnt/datastore/`, removable > +/// datastores will have `/mnt/removable_datastore//` as their path and will be mounted > +/// under `/mnt/removable_datastore/` > pub fn create_datastore_disk( > name: String, > disk: String, > add_datastore: Option, > + removable_datastore: Option, > filesystem: Option, > rpcenv: &mut dyn RpcEnvironment, > ) -> Result { > @@ -154,8 +162,63 @@ pub fn create_datastore_disk( > bail!("disk '{}' is already in use.", disk); > } > > - let mount_point = format!("{}{}", BASE_MOUNT_DIR, &name); > + if let (Some(true), Some(true)) = (add_datastore, removable_datastore) { > + let upid_str = WorkerTask::new_thread( > + "dircreate", > + Some(name.clone()), > + auth_id, > + to_stdout, > + move |worker| { > + task_log!( > + worker, > + "create removable datastore '{}' on disk {}", > + name, > + disk > + ); please inline `name` and `disk` > + > + let filesystem = filesystem.unwrap_or(FileSystemType::Ext4); > + > + let manager = DiskManage::new(); > + > + let disk = manager.disk_by_name(&disk)?; > + > + let partition = create_single_linux_partition(&disk)?; > + create_file_system(&partition, filesystem)?; > + > + let uuid = get_fs_uuid(&partition)?; > + let store_path = format!( > + "{}/{uuid}/{name}", > + pbs_api_types::REMOVABLE_DATASTORE_MOUNT_DIR > + ); > + > + let lock = pbs_config::datastore::lock_config()?; > + let datastore: DataStoreConfig = serde_json::from_value( > + json!({ "name": name, "path": store_path, "backing-device": uuid }), > + )?; > + > + let (config, _digest) = pbs_config::datastore::config()?; > + > + if config.sections.get(&datastore.name).is_some() { > + bail!("datastore '{}' already exists.", datastore.name); > + } > + > + // we don't have to check if the UUID is already in use since we just created the > + // fs ourself > > + crate::api2::config::datastore::do_create_datastore( > + lock, > + config, > + datastore, > + Some(&worker), > + )?; > + > + Ok(()) > + }, > + )?; > + return Ok(upid_str); > + }; > + > + let mount_point = format!("{}{}", BASE_MOUNT_DIR, &name); please inline `BASE_MOUNT_DIR` and `name` > // check if the default path exists already. > // bail if it is not empty or another filesystem mounted on top > let default_path = std::path::PathBuf::from(&mount_point); _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel