From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1C6AC9E0FD for ; Mon, 27 Nov 2023 09:35:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EABE324A0 for ; Mon, 27 Nov 2023 09:35:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 27 Nov 2023 09:35:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A6BD044A30 for ; Mon, 27 Nov 2023 09:35:09 +0100 (CET) Message-ID: Date: Mon, 27 Nov 2023 09:35:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Lukas Wagner , Proxmox Backup Server development discussion References: <20231124120228.180173-1-g.goller@proxmox.com> <20231124120228.180173-4-g.goller@proxmox.com> From: Gabriel Goller In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.372 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_2 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_4 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 3/3] node: status: declutter kernel-version X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2023 08:35:41 -0000 Thanks for the review! On 11/24/23 15:19, Lukas Wagner wrote: > Hi, some comments inline :) > > On 11/24/23 13:02, Gabriel Goller wrote: >> >> diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js >> index 14f84a2e..b1e4ece2 100644 >> --- a/www/panel/NodeInfo.js >> +++ b/www/panel/NodeInfo.js >> @@ -140,11 +140,20 @@ Ext.define('PBS.NodeInfoPanel', { >>           value: '', >>       }, >>       { >> -        itemId: 'kversion', >>           colspan: 2, >>           title: gettext('Kernel Version'), >>           printBar: false, >> -        textField: 'kversion', >> +        // TODO: remove with next major and only use newish >> current-kernel textfield >> +        multiField: true, >> +        //textField: 'current-kernel', > I guess this is not needed? Not currently, as we return both the legacy *and* the new field. As we release the next major version, we will remove the `multiField: true` and uncommment the `textField` property. Same as it has been done in pve. > >> +        renderer: ({ data }) => { >> +            if (!data['current-kernel']) { >> +                return data.kversion; >> +            } >> +                let kernel = data['current-kernel']; >> +                let buildDate = >> kernel.version.match(/\((.+)\)\s*$/)[1] ?? 'unknown'; >> +                return `${kernel.sysname} ${kernel.release} >> (${buildDate})`; > > Identation is off here, spaces instead of tabs+spaces Right! Thanks for the heads up! > >> +        }, >>           value: '', >>       }, >>       { >